Skip to content

Update resumeBuilder.js #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
batmanimal wants to merge 1 commit into
base: solution
Choose a base branch
from
Open

Update resumeBuilder.js #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions js/resumeBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,14 +186,16 @@ function displayEducation() {

$("#education").append(HTMLonlineClasses);

for (course in education.onlineCourses) {
$("#education").append(HTMLschoolStart);

var formattedTitle = HTMLonlineTitle.replace("%data%", education.onlineCourses[course].title);
var formattedSchool = HTMLonlineSchool.replace("%data%",education.onlineCourses[course].school);
var formattedOnlineHeader = formattedTitle + formattedSchool;
for(var course in education.onlineCourses) {
// appended online courses to the new div onlineClassesStart
$("#education").append(HTMLonlineClassesStart);

// updated var naming convention to include "Online"
var formattedOnlineTitle = HTMLonlineTitle.replace("%data%", education.onlineCourses[course].title);
var formattedOnlineSchool= HTMLonlineSchool.replace("%data%", education.onlineCourses[course].school);
var formattedOnlineHeader = formattedOnlineTitle + formattedOnlineSchool;
$(".education-entry:last").append(formattedOnlineHeader);

var formattedDates = HTMLonlineDates.replace("%data%",education.onlineCourses[course].dates);
$(".education-entry:last").append(formattedDates);

Expand All @@ -203,6 +205,12 @@ function displayEducation() {
}
}

// TODO: style better
var formattedURL = HTMLonlineURL.replace("%data%",education.onlineCourses[course].url);
$(".education-entry:last").append(formattedURL);
}
}

function displayFooter() {
for (contact in bio.contacts) {
var formattedContact = HTMLcontactGeneric.replace("%data%", bio.contacts[contact]);
Expand Down Expand Up @@ -234,4 +242,4 @@ function inName(_name) {
$('#main').append(internationalizeButton);

// you want to see a map? here's a map.
$("#mapDiv").append(googleMap);
$("#mapDiv").append(googleMap);