Skip to content
This repository was archived by the owner on Jan 23, 2024. It is now read-only.
This repository was archived by the owner on Jan 23, 2024. It is now read-only.

E-R Diagram Peer Review #2

@DillonRego

Description

@DillonRego

I think that overall it looks good, a few minor things to note however. For ingredients and recipes you have costs values. I see two possible scenarios, in the case of the first you have a cost to view the recipe or something of that nature and everything on that end makes sense. On the other hand you are aggregating the ingredient cost through some means and totaling it to make a cost for the recipe. If that second one is the case then having queries sum the data for you and not having recipe_cost makes more sense. If neither of those are the case feel free to ignore.

Some other minor information to consider. For ingredient_quantities you have a one to one relationship with recipes does that consider multiple preparations/uses for the same ingredient for the same recipe? For example in something like pizza dough, you might have a cup of flour initially, along with a different amount of flour later on. So you would have two different unit types and amounts. Would those be considered a single ingredient quantity? If not then having it be a many to one relationship with recipe makes a bit more sense. For similar reasons to the duplication of data listed above having num_recipies may or may not still make sense.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions