add symfony process as a command wrapper for rector

Author: LordSimal

composer.json

@@ -9,6 +9,7 @@
         "cakephp/console": "^5.1.5",
         "nette/utils": "^4.0",
         "rector/rector": "dev-main",
+        "symfony/process": "^5.4|^6.0|^7.0",
         "symfony/string": "^6.0 || ^7.0"
     },
     "autoload": {

config/rector/sets/cakephp60.php

@@ -362,8 +362,7 @@
                 // Can't rename _moveUp/_moveDown as it conflicts with the TreeBehavior::moveUp()/moveDown() methods
                 // Can't rename _removeFromTree as it conflicts with the TreeBehavior::removeFromTree() method
                 '_setChildrenLevel', '_setParent', '_setAsRoot', '_unmarkInternalTree',
-                '_removeFromTree', '_getNode', '_recoverTree', '_getMax',
-                '_sync', '_scope', '_ensureFields', '_getPrimaryKey',
+                '_getNode', '_recoverTree', '_getMax', '_sync', '_scope', '_ensureFields', '_getPrimaryKey',
             ],
             'Cake\ORM\Behavior\CounterCacheBehavior' => [
                 '_processAssociations', '_processAssociation', '_shouldUpdateCount', '_getCount',

src/Command/RectorCommand.php

@@ -20,6 +20,7 @@
 use Cake\Console\BaseCommand;
 use Cake\Console\ConsoleIo;
 use Cake\Console\ConsoleOptionParser;
+use Symfony\Component\Process\Process;
 
 /**
  * Runs rector rulesets against the provided path.
@@ -59,11 +60,11 @@ public function execute(Arguments $args, ConsoleIo $io): ?int
 
         $result = $this->runRector($io, $args, $autoload);
         if ($result === false) {
-            $io->error('Could not run rector. Ensure that `php` is on your PATH.');
+            $io->error('Something went wrong while running rector. Ensure that `php` is on your PATH.');
 
             return static::CODE_ERROR;
         }
-        $io->success('Rector applied successfully');
+        $io->success('🎉 Upgrade complete! 🎉');
 
         return static::CODE_SUCCESS;
     }
@@ -93,39 +94,28 @@ protected function runRector(ConsoleIo $io, Arguments $args, string $autoload):
         );
         $io->verbose("Running <info>{$command}</info>");
 
-        $descriptorSpec = [
-            0 => ['pipe', 'r'],
-            1 => ['pipe', 'w'],
-            2 => ['pipe', 'w'],
-        ];
-        $process = proc_open(
-            $command,
-            $descriptorSpec,
-            $pipes,
-        );
-        if (!is_resource($process)) {
-            $io->error('Could not create rector process');
+        $io->info('Starting rector at ' . date('Y-m-d H:i:s'));
 
-            return false;
-        }
+        $process = Process::fromShellCommandline($command);
+        $process->setEnv($_ENV);
+        $process->setTimeout(null);
+        $process->start();
 
-        while (true) {
-            if (feof($pipes[1]) && feof($pipes[2])) {
-                break;
-            }
-            $output = fread($pipes[1], 1024);
-            if ($output) {
-                $io->out($output);
-            }
-            $error = fread($pipes[2], 1024);
-            if ($error) {
-                $io->err($error);
+        foreach ($process as $type => $data) {
+            if ($type === Process::OUT) {
+                $io->out($data);
+            } elseif ($type === Process::ERR) {
+                $io->err($data);
             }
         }
 
-        fclose($pipes[1]);
-        fclose($pipes[2]);
-        proc_close($process);
+        if (!$process->isSuccessful()) {
+            $io->error('Something went wrong while running rector.');
+
+            return false;
+        }
+
+        $io->info('Rector completed successfully at ' . date('Y-m-d H:i:s'));
 
         return true;
     }