Merge pull request #363 from cakephp/connection-helper

othercorey · web-flow · commit 1b79098ac6cd · 2025-11-22T09:00:44.000-06:00
Fix connection helper rector processing unrelated nodes
diff --git a/src/Rector/Rector/MethodCall/StaticConnectionHelperRector.php b/src/Rector/Rector/MethodCall/StaticConnectionHelperRector.php
@@ -51,10 +51,10 @@ public function refactor(Node $node): ?Node
                 $parent = $node->getAttribute(AttributeKey::PARENT_NODE);
                 if ($parent instanceof Expression) {
                     $this->removeNode($parent);
-
-                    return null;
                 }
             }
+
+            return null;
         }
 
         // Ensure the node is a method call on the ConnectionHelper instance

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,10 @@ public function refactor(Node $node): ?Node`
`51`	`51`	`$parent = $node->getAttribute(AttributeKey::PARENT_NODE);`
`52`	`52`	`if ($parent instanceof Expression) {`
`53`	`53`	`$this->removeNode($parent);`
`54`		`-`
`55`		`- return null;`
`56`	`54`	`}`
`57`	`55`	`}`
	`56`	`+`
	`57`	`+ return null;`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`// Ensure the node is a method call on the ConnectionHelper instance`