Apply rector fixes

Author: dereuromark

src/BaseSeed.php

@@ -263,8 +263,8 @@ protected function runCall(string $seeder, array $options = []): void
 
         $options += [
             'connection' => $connection,
-            'plugin' => $pluginName ?? ($config !== null ? $config['plugin'] : null),
-            'source' => $config !== null ? $config['source'] : null,
+            'plugin' => $pluginName ?? ($config instanceof \Migrations\Config\ConfigInterface ? $config['plugin'] : null),
+            'source' => $config instanceof \Migrations\Config\ConfigInterface ? $config['source'] : null,
         ];
         $factory = new ManagerFactory([
             'connection' => $options['connection'],

src/Command/BakeMigrationDiffCommand.php

@@ -277,7 +277,10 @@ protected function getColumns(): void
             // changes in columns meta-data
             foreach ($currentColumns as $columnName) {
                 $column = $this->safeGetColumn($currentSchema, $columnName);
-                if ($column === null || !in_array($columnName, $oldColumns, true)) {
+                if ($column === null) {
+                    continue;
+                }
+                if (!in_array($columnName, $oldColumns, true)) {
                     continue;
                 }
 

src/Command/ResetCommand.php

@@ -55,7 +55,7 @@ public static function defaultName(): string
      * @param \Cake\Console\ConsoleOptionParser $parser The option parser to configure
      * @return \Cake\Console\ConsoleOptionParser
      */
-    public function buildOptionParser(ConsoleOptionParser $parser): ConsoleOptionParser
+    protected function buildOptionParser(ConsoleOptionParser $parser): ConsoleOptionParser
     {
         $parser->setDescription([
             'Drop all tables and re-run all migrations.',
@@ -116,7 +116,7 @@ public function execute(Arguments $args, ConsoleIo $io): ?int
         // Get tables to drop
         $tablesToDrop = $this->getTablesToDrop($connection);
 
-        if (empty($tablesToDrop)) {
+        if ($tablesToDrop === []) {
             $io->out('<info>No tables to drop.</info>');
             $io->out('');
             $io->out('Running migrations...');
@@ -204,7 +204,7 @@ protected function dropTables(AdapterInterface $adapter, array $tables, ConsoleI
 
         try {
             foreach ($tables as $table) {
-                $io->verbose("Dropping table: {$table}");
+                $io->verbose('Dropping table: ' . $table);
                 $adapter->dropTable($table);
             }
         } finally {
@@ -248,12 +248,12 @@ protected function runMigrations(Arguments $args, ConsoleIo $io): ?int
         $manager = $factory->createManager($io);
         $config = $manager->getConfig();
 
-        $io->verbose('<info>using connection</info> ' . (string)$args->getOption('connection'));
+        $io->verbose('<info>using connection</info> ' . $args->getOption('connection'));
         $io->verbose('<info>using paths</info> ' . $config->getMigrationPath());
 
         try {
             $start = microtime(true);
-            $manager->migrate(null, false, null);
+            $manager->migrate(null, false);
             $end = microtime(true);
         } catch (Throwable $e) {
             $io->err('<error>' . $e->getMessage() . '</error>');

src/Db/Action/AddCheckConstraint.php

@@ -15,8 +15,6 @@ class AddCheckConstraint extends Action
 {
     /**
      * The check constraint to add
-     *
-     * @var \Migrations\Db\Table\CheckConstraint
      */
     protected CheckConstraint $checkConstraint;
 

src/Db/Action/DropCheckConstraint.php

@@ -14,8 +14,6 @@ class DropCheckConstraint extends Action
 {
     /**
      * The check constraint name to drop
-     *
-     * @var string
      */
     protected string $constraintName;
 

src/Db/Adapter/AbstractAdapter.php

@@ -194,7 +194,7 @@ public function getConnection(): Connection
             $this->connection = $this->getOption('connection');
             $this->connect();
         }
-        if ($this->connection === null) {
+        if (!$this->connection instanceof \Cake\Database\Connection) {
             throw new RuntimeException('Unable to establish database connection. Ensure a connection is configured.');
         }
 

src/Db/Adapter/SqliteAdapter.php

@@ -1124,7 +1124,7 @@ protected function getChangeColumnInstructions(string $tableName, string $column
     {
         $instructions = $this->beginAlterByCopyTable($tableName);
 
-        $newColumnName = (string)$newColumn->getName();
+        $newColumnName = $newColumn->getName();
         $instructions->addPostStep(function (array $state) use ($columnName, $newColumn): array {
             $dialect = $this->getSchemaDialect();
             $sql = (string)preg_replace(

src/Db/Adapter/SqlserverAdapter.php

@@ -297,7 +297,7 @@ public function disableForeignKeyConstraints(): void
         foreach ($rows as $row) {
             $constraintName = $this->quoteColumnName($row['constraint_name']);
             $tableName = $this->quoteTableName($row['table_name']);
-            $this->execute("ALTER TABLE {$tableName} DROP CONSTRAINT {$constraintName}");
+            $this->execute(sprintf('ALTER TABLE %s DROP CONSTRAINT %s', $tableName, $constraintName));
         }
     }
 

src/Db/Table.php

@@ -369,7 +369,7 @@ public function addColumn(string|Column $columnName, ?string $type = null, array
             throw new InvalidArgumentException(sprintf(
                 'An invalid column type "%s" was specified for column "%s".',
                 $column->getType(),
-                (string)$column->getName(),
+                $column->getName(),
             ));
         }
 
@@ -1186,7 +1186,7 @@ protected function executeActions(bool $exists): void
             }
 
             // Only skip CreateTable if we have ONLY view/trigger actions (and at least one)
-            if (!$hasViewOrTriggerActions || $hasTableActions || count($actions) === 0) {
+            if (!$hasViewOrTriggerActions || $hasTableActions || $actions === []) {
                 $this->actions->addAction(new CreateTable($this->table));
             }
         }

src/Util/TableFinder.php

@@ -178,7 +178,7 @@ public function fetchTableName(string $className, ?string $pluginName = null): a
         $table = TableRegistry::getTableLocator()->get($className);
         foreach ($table->associations()->keys() as $key) {
             $association = $table->associations()->get($key);
-            if ($association !== null && $association->type() === 'belongsToMany') {
+            if ($association instanceof \Cake\ORM\Association && $association->type() === 'belongsToMany') {
                 /** @var \Cake\ORM\Association\BelongsToMany $belongsToMany */
                 $belongsToMany = $association;
                 $tables[] = $belongsToMany->junction()->getTable();