Fix up DateTime support.

Author: dereuromark

tests/TestCase/Command/Phinx/SeedTest.php

@@ -21,6 +21,7 @@
 use Migrations\Test\CommandTester;
 use Migrations\Test\TestCase\DriverConnectionTrait;
 use PDO;
+use Phinx\Config\FeatureFlags;
 use Phinx\Db\Adapter\WrapperInterface;
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\StreamOutput;
@@ -90,6 +91,8 @@ public function tearDown(): void
         $this->connection->execute('DROP TABLE IF EXISTS numbers');
         $this->connection->execute('DROP TABLE IF EXISTS letters');
         $this->connection->execute('DROP TABLE IF EXISTS stores');
+
+        FeatureFlags::$addTimestampsUseDateTime = false;
     }
 
     /**

tests/TestCase/Command/SeedCommandTest.php

@@ -11,6 +11,7 @@
 use Cake\Event\EventManager;
 use Cake\TestSuite\TestCase;
 use InvalidArgumentException;
+use Phinx\Config\FeatureFlags;
 use ReflectionProperty;
 
 class SeedCommandTest extends TestCase
@@ -141,7 +142,7 @@ public function testSeederBaseSeed(): void
         $this->assertEquals(2, $query->fetchColumn(0));
     }
 
-    public function testSeederImplictAll(): void
+    public function testSeederImplicitAll(): void
     {
         $this->createTables();
         $this->exec('migrations seed -c test');
@@ -192,4 +193,58 @@ public function testSeederSourceNotFound(): void
 
         $this->exec('migrations seed -c test --source NotThere --seed LettersSeed');
     }
+
+    public function testSeederWithDateTimeFields(): void
+    {
+        FeatureFlags::$addTimestampsUseDateTime = true;
+
+        $this->createTables();
+        $this->exec('migrations seed -c test --seed StoresSeed');
+
+        $this->assertExitSuccess();
+        $this->assertOutputContains('StoresSeed:</info> <comment>seeding');
+        $this->assertOutputContains('All Done');
+
+        /** @var \Cake\Database\Connection $connection */
+        $connection = ConnectionManager::get('test');
+        $result = $connection->selectQuery()
+            ->select(['*'])
+            ->from('stores')
+            ->orderBy('id DESC')
+            ->limit(1)
+            ->execute()->fetchAll('assoc');
+
+        $this->assertNotEmpty($result[0]);
+        $store = $result[0];
+        $this->assertEquals('foo_with_date', $store['name']);
+        $this->assertNotEmpty($store['created']);
+        $this->assertNotEmpty($store['modified']);
+    }
+
+    public function testSeederWithTimestampFields(): void
+    {
+        FeatureFlags::$addTimestampsUseDateTime = false;
+
+        $this->createTables();
+        $this->exec('migrations seed -c test --seed StoresSeed');
+
+        $this->assertExitSuccess();
+        $this->assertOutputContains('StoresSeed:</info> <comment>seeding');
+        $this->assertOutputContains('All Done');
+
+        /** @var \Cake\Database\Connection $connection */
+        $connection = ConnectionManager::get('test');
+        $result = $connection->selectQuery()
+            ->select(['*'])
+            ->from('stores')
+            ->orderBy('id DESC')
+            ->limit(1)
+            ->execute()->fetchAll('assoc');
+
+        $this->assertNotEmpty($result[0]);
+        $store = $result[0];
+        $this->assertEquals('foo_with_date', $store['name']);
+        $this->assertNotEmpty($store['created']);
+        $this->assertNotEmpty($store['modified']);
+    }
 }

tests/test_app/config/Seeds/NumbersSeed.php

@@ -9,11 +9,6 @@ class NumbersSeed extends AbstractSeed
 {
     /**
      * Run Method.
-     *
-     * Write your database seeder using this method.
-     *
-     * More information on writing seeders is available here:
-     * https://book.cakephp.org/phinx/0/en/seeding.html
      */
     public function run(): void
     {

tests/test_app/config/Seeds/StoresSeed.php

@@ -0,0 +1,33 @@
+<?php
+
+use Cake\I18n\Date;
+use Cake\I18n\DateTime;
+use Migrations\AbstractSeed;
+
+/**
+ * NumbersSeed seed.
+ */
+class StoresSeed extends AbstractSeed
+{
+    /**
+     * Run Method.
+     */
+    public function run(): void
+    {
+        $data = [
+            [
+                'name' => 'foo',
+                'created' => new Date(),
+                'modified' => new Date(),
+            ],
+            [
+                'name' => 'foo_with_date',
+                'created' => new DateTime(),
+                'modified' => new DateTime(),
+            ],
+        ];
+
+        $table = $this->table('stores');
+        $table->insert($data)->save();
+    }
+}