Trait declaration mismatch on 8.4

[adominodsq]

Running on PHP 8.4.5 gives the following error with chronos 2.4.5:

In FactoryTrait.php line 339:

Declaration of Cake\Chronos\Traits\FactoryTrait::createFromTimestamp(int $timestamp, $tz = null): Cake\Chronos\ChronosInterface must be compatible with DateTimeImmutable::createFromTimestamp(int|float $timestamp): static

Updating FactoryTrait.php:339 to allow the timestamp to be an int or float fixes the issue.

[dereuromark]

Are you using an outdated version of the library?

chronos/src/Chronos.php

Line 743 in e5377b2

public static function createFromTimestamp(float|int $timestamp, DateTimeZone|string|null $timezone = null): static

This was all documented and released with https://github.com/cakephp/chronos/releases/tag/3.1.0

[dereuromark]

You could make a backport PR for 2.x (and 2.5.0) and we could discuss a fitting backport release.
It is technically not fully BC, so if someone already extended it they would run into issues.
So that long ago after the v2 releases I am not sure if that's a viable approach.

Is there a reason you cannot use v3?

In the meantime I updated the https://github.com/cakephp/chronos/wiki#version-map to reflect the current min/max.

[dereuromark]

PR open: #474