Skip to content

Commit f3ec475

Browse files
committed
Allow float timestamp argument for createFromTimestamp to match PHP 8.4
1 parent b0321ab commit f3ec475

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ jobs:
1717
strategy:
1818
fail-fast: false
1919
matrix:
20-
php-version: ['7.4', '8.0', '8.1', '8.2']
20+
php-version: ['8.4']
2121
prefer-lowest: ['']
2222
include:
23-
- php-version: '7.2'
23+
- php-version: '8.4'
2424
prefer-lowest: 'prefer-lowest'
2525

2626
steps:
@@ -56,19 +56,19 @@ jobs:
5656
fi
5757
5858
- name: Setup problem matchers for PHPUnit
59-
if: matrix.php-version == '7.4'
59+
if: matrix.php-version == '8.4'
6060
run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
6161

6262
- name: Run PHPUnit
6363
run: |
64-
if [[ ${{ matrix.php-version }} == '7.4' ]]; then
64+
if [[ ${{ matrix.php-version }} == '8.4' ]]; then
6565
export CODECOVERAGE=1 && vendor/bin/phpunit --verbose --coverage-clover=coverage.xml
6666
else
6767
vendor/bin/phpunit
6868
fi
6969
7070
- name: Submit code coverage
71-
if: matrix.php-version == '7.4'
71+
if: matrix.php-version == '8.4'
7272
uses: codecov/codecov-action@v3
7373

7474
cs-stan:

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"source": "https://github.com/cakephp/chronos"
2626
},
2727
"require": {
28-
"php": ">=7.2"
28+
"php": ">=8.0"
2929
},
3030
"require-dev": {
3131
"phpunit/phpunit": "^8.0 || ^9.0",

src/Traits/FactoryTrait.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,11 +332,11 @@ public static function createFromArray(array $values): ChronosInterface
332332
/**
333333
* Create a ChronosInterface instance from a timestamp
334334
*
335-
* @param int $timestamp The timestamp to create an instance from.
335+
* @param float|int $timestamp The timestamp to create an instance from.
336336
* @param \DateTimeZone|string|null $tz The DateTimeZone object or timezone name the new instance should use.
337337
* @return static
338338
*/
339-
public static function createFromTimestamp(int $timestamp, $tz = null): ChronosInterface
339+
public static function createFromTimestamp(float|int $timestamp, $tz = null): ChronosInterface
340340
{
341341
$instance = static::now($tz)->setTimestamp($timestamp);
342342
if (get_class($instance) === ChronosDate::class) {

0 commit comments

Comments
 (0)