Don't populate IdentifierCollection errors with empty nested arrays

Author: ADmad

src/Identifier/IdentifierCollection.php

@@ -56,7 +56,11 @@ public function identify(array $credentials): ArrayAccess|array|null
 
                 return $result;
             }
-            $this->_errors[$name] = $identifier->getErrors();
+
+            $errors = $identifier->getErrors();
+            if ($errors) {
+                $this->_errors[$name] = $identifier->getErrors();
+            }
         }
 
         $this->_successfulIdentifier = null;

tests/TestCase/Authenticator/FormAuthenticatorTest.php

@@ -112,6 +112,27 @@ public function testCredentialsEmpty()
         $this->assertEquals([0 => 'Login credentials not found'], $result->getErrors());
     }
 
+    public function testIdentityNotFound()
+    {
+        $identifiers = new IdentifierCollection([
+           'Authentication.Password',
+        ]);
+
+        $request = ServerRequestFactory::fromGlobals(
+            ['REQUEST_URI' => '/users/does-not-match'],
+            [],
+            ['username' => 'non-existent', 'password' => 'password'],
+        );
+
+        $form = new FormAuthenticator($identifiers);
+
+        $result = $form->authenticate($request);
+
+        $this->assertInstanceOf(Result::class, $result);
+        $this->assertSame(Result::FAILURE_IDENTITY_NOT_FOUND, $result->getStatus());
+        $this->assertSame([], $result->getErrors());
+    }
+
     /**
      * testSingleLoginUrlMismatch
      *