In general, add ESM CJS library in standalone 5.x

[cristianvogel]

I know its a pain, but it works well for older CJS libs.

So I am trying to get https://www.npmjs.com/package/bonjour-service in to my patch.

I have grabbed the source code locally. I have tried building with WebPack....

"build:webpack": "webpack --config webpack.config.js"

a config like this

const path = require('path');

module.exports = {
  entry: './src/index.ts',
  target: 'node',
  mode: 'production',
  module: {
    rules: [
      {
        test: /\.tsx?$/,
        use: 'ts-loader',
        exclude: /node_modules/,
      },
    ],
  },
  resolve: {
    extensions: ['.tsx', '.ts', '.js'],
  },
  output: {
    filename: 'bonjour-service.cjs.js',
    path: path.resolve(__dirname, 'dist'),
    library: {
      type: 'commonjs2'
    }
  },
  optimization: {
    minimize: false
  }
};

and get a js file out successfully.

bonjour-service.cjs.js

nice.

In Cables 5.2.0 I can import it using the CommonJS add. No problem.

But in my op code, it fails.

I am trying to import like this

const bonjour = op.require('bonjour-service.cjs.js');

This is the Cables console error log.

Log Object Arg 0: [Object]
[platform] 
[LoadingStatus] finished loading 1 assets in 0.345s
[LoadingStatus] finished loading 1 assets in 0.109s
}
    "0": "cables:///api/oplib/Ops.Local.BonjourService_v1/bonjour-service.cjs.js",
{
Log Object Arg 0: [Array]
[libloader] 
[core_patch] [instancing error] Ops.Local.BonjourService_v1
[core_patch] [TypeError] this._log.error is not a function
CABLES.Op.require	file:///Applications/cables-0.5.2.app/Contents/Resources/app.asar/dist/public/js/scripts.electron.js@1:33883
[core_patch] Object._opRequire	file:///Applications/cables-0.5.2.app/Contents/Resources/app.asar/dist/public/js/scripts.electron.js@1:35493
[core_patch] addop: op could not be created: Ops.Local.BonjourService_v1
[LogTab] file: "scripts" line 0: (()=>{var e={"../shared/client/libs/talker.cjs":e=>{e.exports=function(e){let t={};function n(r){if(t[r])return t[r].exports;let i=t[r]={i:r,l:!1,expo...
[core_patch] [instancing error] Ops.Local.BonjourService_v1
[core_patch] [TypeError] this._log.error is not a function
CABLES.Op.require	file:///Applications/cables-0.5.2.app/Contents/Resources/app.asar/dist/public/js/scripts.electron.js@1:33883
[core_patch] Object._opRequire	file:///Applications/cables-0.5.2.app/Contents/Resources/app.asar/dist/public/js/scripts.electron.js@1:35493
[core_patch] addop: op could not be created: Ops.Local.BonjourService_v1

[steam0r]

what didn't work when simply adding this via op-dependencies?

[steam0r]

If you add it as commonjs in the current dev, then you no longer use op.require. this needs more documentation after implemented properly. thanks for the feedback!