Skip to content

chore: remove tidy target from Makefile #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ken-matsui merged 1 commit into from
Oct 29, 2025
Merged

chore: remove tidy target from Makefile #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ standards by running the following tools:
```
3. Run the static analyzer (`clang-tidy`)
```bash
cabin tidy # or make tidy
cabin tidy
```

### Testing
Expand Down
10 changes: 1 addition & 9 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
CXX ?= clang++
CABIN_TIDY ?= clang-tidy
GIT ?= git
PREFIX ?= /usr/local
INSTALL ?= install
Expand Down Expand Up @@ -63,12 +62,10 @@ UNITTEST_OBJS := $(patsubst src/%,$(O)/tests/test_%,$(UNITTEST_SRCS:.cc=.o))
UNITTEST_BINS := $(UNITTEST_OBJS:.o=)
UNITTEST_DEPS := $(UNITTEST_OBJS:.o=.d)

TIDY_TARGETS := $(patsubst src/%,tidy_%,$(SRCS))

GIT_DEPS := $(O)/DEPS/toml11 $(O)/DEPS/mitama-cpp-result


.PHONY: all clean install test versions tidy $(TIDY_TARGETS)
.PHONY: all clean install test versions


all: check_deps $(PROJECT)
Expand Down Expand Up @@ -142,11 +139,6 @@ $(O)/tests/test_Builder/Project: $(O)/tests/test_Builder/Project.o $(O)/Algos.o
$(CXX) $(TEST_LDFLAGS) $^ $(LIBS) $(LDFLAGS) -o $@


tidy: $(TIDY_TARGETS)

$(TIDY_TARGETS): tidy_%: src/% $(GIT_DEPS)
$(CABIN_TIDY) $(CABIN_TIDY_FLAGS) $< -- $(CXXFLAGS) $(DEFINES) -DCABIN_TEST $(INCLUDES)

install: all
$(INSTALL) -m 0755 -d $(DESTDIR)$(PREFIX)/bin
$(INSTALL) -m 0755 $(PROJECT) $(DESTDIR)$(PREFIX)/bin
Expand Down
Loading