Large Map and Arrays don't deserialize properly

[knopp]

When checking for FixArray and FixMap wrong mask is used, resulting in 16 and 32 bit array/map being decoded as fix array/map.

Similar problem with fix string. The check for FixString would also match negative fixnum, however this works because negative fixnum is matched first during decoding. Still a bug though.

[rajmaniar]

Is there a chance this can get merged soon?
I feel like it's been aged to the peak of perfection now... 😆

[knopp]

@rajmaniar, i'd recommend against using this package. This is not the only issue with it, (see #3). I considered forking and fixing it, but the overall code quality is pretty bad so I just took our in-house c++ implementation and ported it to dart.

[rajmaniar]

Lol...I came to the same conclusion after diving into the code so I switched over to the msgpack_dart already. Thanks for porting!

…

On Jul 10, 2019, at 4:14 PM, Matej Knopp ***@***.***> wrote: @rajmaniar, i'd recommend against using this package. This is not the only issue with it, (see #3). I consider forking and fixing it, but the overall code quality is pretty bad so I just took our in-house c++ implementation and ported it to dart. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.