-
Notifications
You must be signed in to change notification settings - Fork 2
Description
We should have some kind of CD to automate the deployment.
A feature will request and discussed on, then mockups made if it's a visual feature
then it'll designed, if it's not visual first the unit testing of the feature with the
implementation of the feature then a pull request will be made, if all travis tests pass,
get a review on the pull request from the top-dog.
Each pull request contains a link that allows to preview and test the changes that were made. The developer sends this link to the client. The client uses it to review the changes that were made.
If approved then everything will be merged into the master branch.
Then it is deployed into production.
which will then already be in production.
Thereafter... be merged into the master branch.
which will then be merged and delpoyed then can go to the
Q&A session by Kimon
--->deployment
it's already hosted to heroku so i'm not sure we need more
Michael's version:
For each pull request the application will be deployed on a test staging system from where the client can review and approve the current changes.
How is it deployed to the staging system and where is it set up?
Netlifly does a new deployment for you for each pull request. But this will probably not be possible for this application, because Netlifly does not support ruby on rails projects it would show static pages.
--
Review comments by Michael:
discuss the end, how it is really rolled out, how it is really deployed.
Also how do you do the QA.
If all travis tests pass get a review by whom
then it should be merged. merged into where. master / main branch.
And deployed. That's the important question. Deployed to where? Because you say "can go to the QA session by Kimon". In that phase Kimon or the client, it's their first time to see it. Then you might have to have another iteration for changes. So it shouldn't be in production before the QA. It should be on a staging system.
When you describe the deployment, explain how it is done and who does it.
Get a review from the client. How does the client review it. Where can the client see it?
--
The purpose of this is to have a process that allows the client to review the work before it is brought to production. That's what we would need a staging system for