From 37edfffe621a163224b49538184b1997e1c86cd2 Mon Sep 17 00:00:00 2001 From: Stefan VanBuren Date: Thu, 22 Jan 2026 14:36:39 -0500 Subject: [PATCH 1/4] Enable playwright tests on Windows --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 2cbe230..92aa186 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -57,7 +57,7 @@ jobs: # NOTE: We disable playwright tests when buf is not installed on the system $PATH # for now so we don't have the extension attempting to resolve the installation. # We'll need to find a way to intercept the call from playwright's VS Code extension. - if: runner.os == 'macOS' && matrix.buf-bin-setup == 'buf-on-path' + if: (runner.os == 'macOS' || runner.os == 'windows') && matrix.buf-bin-setup == 'buf-on-path' - name: check diff run: node scripts/gh-diffcheck.mjs - name: upload-playwright-test-results From be232bc877e8eb30003ab07294f3a78e01210cbc Mon Sep 17 00:00:00 2001 From: Stefan VanBuren Date: Thu, 22 Jan 2026 14:44:25 -0500 Subject: [PATCH 2/4] Convert uri.path usage to .fsPath .path makes sense for unix-like OSes, but doesn't work on Windows. Fixes #522. --- src/commands/buf-build.ts | 2 +- src/commands/buf-config-init.ts | 2 +- src/commands/buf-dep-prune.ts | 2 +- src/commands/buf-dep-update.ts | 2 +- src/commands/buf-generate.ts | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/commands/buf-build.ts b/src/commands/buf-build.ts index a1f8f6a..8e41038 100644 --- a/src/commands/buf-build.ts +++ b/src/commands/buf-build.ts @@ -29,7 +29,7 @@ export const bufBuild = new Command( args.push("-o", outPath); } for (const workspaceFolder of vscode.workspace.workspaceFolders) { - bufState.execBufCommand(args, workspaceFolder.uri.path); + bufState.execBufCommand(args, workspaceFolder.uri.fsPath); } } ); diff --git a/src/commands/buf-config-init.ts b/src/commands/buf-config-init.ts index a7f5fc2..239e649 100644 --- a/src/commands/buf-config-init.ts +++ b/src/commands/buf-config-init.ts @@ -15,7 +15,7 @@ export const bufConfigInit = new Command( return; } for (const workspaceFolder of vscode.workspace.workspaceFolders) { - bufState.execBufCommand(["config", "init"], workspaceFolder.uri.path); + bufState.execBufCommand(["config", "init"], workspaceFolder.uri.fsPath); } } ); diff --git a/src/commands/buf-dep-prune.ts b/src/commands/buf-dep-prune.ts index 1439948..a569210 100644 --- a/src/commands/buf-dep-prune.ts +++ b/src/commands/buf-dep-prune.ts @@ -17,7 +17,7 @@ export const bufDepPrune = new Command( return; } for (const workspaceFolder of vscode.workspace.workspaceFolders) { - bufState.execBufCommand(["dep", "prune"], workspaceFolder.uri.path); + bufState.execBufCommand(["dep", "prune"], workspaceFolder.uri.fsPath); } } ); diff --git a/src/commands/buf-dep-update.ts b/src/commands/buf-dep-update.ts index cc3cb6c..9f7c62a 100644 --- a/src/commands/buf-dep-update.ts +++ b/src/commands/buf-dep-update.ts @@ -16,7 +16,7 @@ export const bufDepUpdate = new Command( return; } for (const workspaceFolder of vscode.workspace.workspaceFolders) { - bufState.execBufCommand(["dep", "update"], workspaceFolder.uri.path); + bufState.execBufCommand(["dep", "update"], workspaceFolder.uri.fsPath); } } ); diff --git a/src/commands/buf-generate.ts b/src/commands/buf-generate.ts index d976fd9..1d1d23f 100644 --- a/src/commands/buf-generate.ts +++ b/src/commands/buf-generate.ts @@ -16,7 +16,7 @@ export const bufGenerate = new Command( return; } for (const workspaceFolder of vscode.workspace.workspaceFolders) { - bufState.execBufCommand(["generate"], workspaceFolder.uri.path); + bufState.execBufCommand(["generate"], workspaceFolder.uri.fsPath); } } ); From f346db8d012c4d318d74be4fa0d2e799c608b86c Mon Sep 17 00:00:00 2001 From: Stefan VanBuren Date: Thu, 22 Jan 2026 14:54:07 -0500 Subject: [PATCH 3/4] Revert "Enable playwright tests on Windows" This reverts commit 37edfffe621a163224b49538184b1997e1c86cd2. Doesn't seem to work; not quite sure why. --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 92aa186..2cbe230 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -57,7 +57,7 @@ jobs: # NOTE: We disable playwright tests when buf is not installed on the system $PATH # for now so we don't have the extension attempting to resolve the installation. # We'll need to find a way to intercept the call from playwright's VS Code extension. - if: (runner.os == 'macOS' || runner.os == 'windows') && matrix.buf-bin-setup == 'buf-on-path' + if: runner.os == 'macOS' && matrix.buf-bin-setup == 'buf-on-path' - name: check diff run: node scripts/gh-diffcheck.mjs - name: upload-playwright-test-results From a6afcccf219a64d4a75a98fe9e051b7e2bf9ffe7 Mon Sep 17 00:00:00 2001 From: Stefan VanBuren Date: Thu, 22 Jan 2026 15:38:29 -0500 Subject: [PATCH 4/4] Use fsPath in one more place No more `uri.path` usage. --- src/state.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/state.ts b/src/state.ts index 1ba788e..906784d 100644 --- a/src/state.ts +++ b/src/state.ts @@ -364,7 +364,7 @@ export const bufState = new BufState(); function getBinaryPathForRelConfigPath(configPath: string): string { if (vscode.workspace.workspaceFolders) { for (const workspaceFolder of vscode.workspace.workspaceFolders) { - const joinedPath = path.join(workspaceFolder.uri.path, configPath); + const joinedPath = path.join(workspaceFolder.uri.fsPath, configPath); if (fs.existsSync(joinedPath)) { return joinedPath; }