From dd07c6e2b4823bc736960d9455007ad385643c07 Mon Sep 17 00:00:00 2001 From: Sri Krishna Date: Wed, 3 Dec 2025 01:14:16 +0530 Subject: [PATCH 1/2] Make it so that you can define expression-only rules Signed-off-by: Sri Krishna --- protovalidate/internal/rules.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/protovalidate/internal/rules.py b/protovalidate/internal/rules.py index 8dbe5a2..2875667 100644 --- a/protovalidate/internal/rules.py +++ b/protovalidate/internal/rules.py @@ -348,13 +348,16 @@ def _validate_cel( result = cel.runner.evaluate(activation) if isinstance(result, celtypes.BoolType): if not result: + message = cel.rule.message + if len(message) == 0: + message = "\"{}\" returned false".format(cel.rule.expression) ctx.add( Violation( field_value=this_value, rule=cel.rule_path, rule_value=cel.rule_value, rule_id=cel.rule.id, - message=cel.rule.message, + message=message, for_key=for_key, ), ) From 921c9b65ab76ab8cd1c51864c57d6c2c5288d28f Mon Sep 17 00:00:00 2001 From: Sri Krishna <93153132+srikrsna-buf@users.noreply.github.com> Date: Wed, 3 Dec 2025 13:58:18 +0530 Subject: [PATCH 2/2] Update protovalidate/internal/rules.py Co-authored-by: Stefan VanBuren --- protovalidate/internal/rules.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protovalidate/internal/rules.py b/protovalidate/internal/rules.py index 2875667..ee2a896 100644 --- a/protovalidate/internal/rules.py +++ b/protovalidate/internal/rules.py @@ -350,7 +350,7 @@ def _validate_cel( if not result: message = cel.rule.message if len(message) == 0: - message = "\"{}\" returned false".format(cel.rule.expression) + message = f'"{cel.rule.expression}" returned false' ctx.add( Violation( field_value=this_value,