From 35cefe719696f348a05cc0a73e2bf0cea4a9ebae Mon Sep 17 00:00:00 2001 From: Saquib Mian Date: Thu, 14 Nov 2024 13:34:44 -0500 Subject: [PATCH] Bump `protocolbuffers/csharp@28.3` to `netstandard2.0` .NET 9 SDK raises a (suppressable) build warning about this, largely to encourage developers to upgrade. This should not be an issue for consumers, as the more important consideration is the hosting application's target framework. More importantly, using `netstandard1.1` results in a vulnerable version of `System.Net.Http` being pulled in (`4.3.0`) via `Google.Protobuf`'s `netstandard1.1` deps. Upgrading to `netstandard2.0` resolves this. `grpc/csharp` is already using `netstandard2.0`. No other C# plugins exist. --- plugins/protocolbuffers/csharp/v28.3/buf.plugin.yaml | 2 +- plugins/protocolbuffers/csharp/v28.3/build.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/protocolbuffers/csharp/v28.3/buf.plugin.yaml b/plugins/protocolbuffers/csharp/v28.3/buf.plugin.yaml index 80d2c1a47..1a489c73b 100644 --- a/plugins/protocolbuffers/csharp/v28.3/buf.plugin.yaml +++ b/plugins/protocolbuffers/csharp/v28.3/buf.plugin.yaml @@ -12,7 +12,7 @@ registry: - base_namespace= nuget: target_frameworks: - - netstandard1.1 + - netstandard2.0 deps: - name: Google.Protobuf version: 3.28.3 diff --git a/plugins/protocolbuffers/csharp/v28.3/build.csproj b/plugins/protocolbuffers/csharp/v28.3/build.csproj index df69d3d87..88b3e73f5 100644 --- a/plugins/protocolbuffers/csharp/v28.3/build.csproj +++ b/plugins/protocolbuffers/csharp/v28.3/build.csproj @@ -1,6 +1,6 @@ - netstandard1.1 + netstandard2.0