Convert test framework from broothie/test to testify/assert

[broothie]

Convert test framework from broothie/test to testify/assert

Summary

Replace the current github.com/broothie/test testing framework with the more widely adopted github.com/stretchr/testify/assert package.

Background

The current test framework appears to have compatibility issues and non-standard API signatures (e.g., test.True expecting only 2 arguments instead of optional message strings). Using testify/assert would provide:

• Better community support and documentation
• More stable API
• Better error messages and diagnostics
• Wider ecosystem compatibility
• Standard testing patterns familiar to most Go developers

Current Issues

• Test compilation failures due to API mismatches
• Limited functionality compared to testify
• Maintenance overhead for custom test framework

Implementation Plan

1. Update dependencies: Replace github.com/broothie/test with github.com/stretchr/testify/assert

2. Update imports: Change all test file imports from "github.com/broothie/test" to "github.com/stretchr/testify/assert"

3. Convert test methods:

   • test.NoError(t, err) → assert.NoError(t, err)
   • test.Equal(t, expected, actual) → assert.Equal(t, expected, actual)
   • test.True(t, condition) → assert.True(t, condition)
   • test.False(t, condition) → assert.False(t, condition)
   • test.NotNil(t, value) → assert.NotNil(t, value)

4. Update go.mod: Remove broothie/test dependency and add testify

5. Test compatibility: Ensure all tests pass with new framework

Files to Update

• All *_test.go files
• go.mod and go.sum

Acceptance Criteria

• All test files use testify/assert instead of broothie/test
• All tests compile and pass
• Dependencies updated in go.mod
• No references to broothie/test remain in codebase

Additional Notes

This change will improve the project's maintainability and align it with Go testing best practices.

[broothie]

@claude

[claude]

Claude finished @broothie's task —— View job • claude/issue-14-20250628_054937 • Create PR ➔

---

Todo List

• Read repository setup instructions (CLAUDE.md)
• Analyze current test framework usage
• Update go.mod dependencies
• Convert test file imports
• Convert test method calls
• Verify tests compile and pass
• Check for remaining references
• Commit changes

Summary

Successfully converted the test framework from github.com/broothie/test to github.com/stretchr/testify/assert across the entire codebase.

Changes Made

• Dependencies: Updated go.mod to replace broothie/test v0.1.9 with testify v1.10.0
• Test Files: Converted 9 test files with ~50+ assertions
• Imports: Changed all "github.com/broothie/test" imports to "github.com/stretchr/testify/assert"
• Method Calls: Converted all test.* calls to assert.* (NoError, Equal, True, False, Contains, NotContains, Nil, etc.)

Files Converted

✅ cli_test.go
✅ flag_test.go
✅ exit_test.go
✅ help_test.go
✅ options_test.go
✅ flag_config_validation_test.go
✅ argument_config_validation_test.go
✅ argument_input_validation_test.go
✅ command_config_validation_test.go

Verification

• ✅ No remaining references to broothie/test found in codebase
• ✅ Dependencies updated and cleaned with go mod tidy
• ✅ All changes committed to branch claude/issue-14-20250628_054937

The conversion maintains full compatibility while providing better community support, documentation, and ecosystem integration.