Skip to content

Don't perform io.ReadAll on http response #4

@brianredbeard

Description

@brianredbeard

As per @mischief:

[15:43]  don't readfull here https://github.com/brianredbeard/gpget/blob/master/main.go#L136
[15:43]  your File.content could probably just be a io.Reader
[15:44]  if someone tries to e.g. download a 8G disk image with this, and they only have 8G memory, it will just OOM

Fixes issue called out in TODO.md

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions