From fef133c384b9e060dbce5652c327b1280feafc53 Mon Sep 17 00:00:00 2001 From: francesco Date: Tue, 16 Dec 2025 09:59:18 +0100 Subject: [PATCH 1/4] perf: perf: no need to create a new array and new anonymous function --- packages/pg-pool/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pg-pool/index.js b/packages/pg-pool/index.js index 3e505f797..7efd0ffcd 100644 --- a/packages/pg-pool/index.js +++ b/packages/pg-pool/index.js @@ -125,7 +125,7 @@ class Pool extends EventEmitter { if (this.ending) { this.log('pulse queue on ending') if (this._idle.length) { - this._idle.slice().map((item) => { + for (const item of this._idle) { this._remove(item.client) }) } From 02c2f96de5c7528cd11715f953670120659f526b Mon Sep 17 00:00:00 2001 From: francesco Date: Tue, 16 Dec 2025 10:01:29 +0100 Subject: [PATCH 2/4] fix: lint --- packages/pg-pool/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pg-pool/index.js b/packages/pg-pool/index.js index 7efd0ffcd..6a1676a9e 100644 --- a/packages/pg-pool/index.js +++ b/packages/pg-pool/index.js @@ -127,7 +127,7 @@ class Pool extends EventEmitter { if (this._idle.length) { for (const item of this._idle) { this._remove(item.client) - }) + } } if (!this._clients.length) { this.ended = true From f9f46f24fe85da3e180dd4e2c7e76638cd81ce14 Mon Sep 17 00:00:00 2001 From: francesco Date: Tue, 16 Dec 2025 11:32:59 +0100 Subject: [PATCH 3/4] fix: loop --- packages/pg-pool/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/pg-pool/index.js b/packages/pg-pool/index.js index 6a1676a9e..0de63f9e0 100644 --- a/packages/pg-pool/index.js +++ b/packages/pg-pool/index.js @@ -125,7 +125,8 @@ class Pool extends EventEmitter { if (this.ending) { this.log('pulse queue on ending') if (this._idle.length) { - for (const item of this._idle) { + for (let i = this._idle.length - 1; i >= 0; i--) { + const item = this._idle[i] this._remove(item.client) } } From fb63bebbc2b28e95cb6ee48622ff78ed87d376ac Mon Sep 17 00:00:00 2001 From: francesco Date: Wed, 17 Dec 2025 08:55:14 +0100 Subject: [PATCH 4/4] chore: remove if --- packages/pg-pool/index.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/pg-pool/index.js b/packages/pg-pool/index.js index 0de63f9e0..cc450339a 100644 --- a/packages/pg-pool/index.js +++ b/packages/pg-pool/index.js @@ -124,11 +124,9 @@ class Pool extends EventEmitter { } if (this.ending) { this.log('pulse queue on ending') - if (this._idle.length) { - for (let i = this._idle.length - 1; i >= 0; i--) { - const item = this._idle[i] - this._remove(item.client) - } + for (let i = this._idle.length - 1; i >= 0; i--) { + const item = this._idle[i] + this._remove(item.client) } if (!this._clients.length) { this.ended = true