From 1cb4642300960d39de2b5c680cf213b406809601 Mon Sep 17 00:00:00 2001 From: Brennan Douglas Date: Fri, 27 Sep 2019 21:19:24 -0700 Subject: [PATCH 1/2] fix(charts): add title back to charts object --- src/components/chart.vue | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/components/chart.vue b/src/components/chart.vue index b89f40e..fbf0f75 100644 --- a/src/components/chart.vue +++ b/src/components/chart.vue @@ -70,9 +70,12 @@ export default Vue.extend({ } }; - const config: ChartConfiguration = { + const config = { // bind it to this instance of the component bindto: this.$el, + title: { + text: this.title + }, data: { xs, //xFormat: '%m/%d/%Y %H:%M', @@ -89,7 +92,7 @@ export default Vue.extend({ }, legend: { item: { - onclick: id => { + onclick: (id: any) => { if (this.focusItems.includes(id)) { this.focusItems = this.focusItems.filter(v => v !== id); } else { @@ -97,10 +100,10 @@ export default Vue.extend({ } chart.focus(this.focusItems); }, - onmouseover: id => { + onmouseover: (id: any) => { chart.focus([id, ...this.focusItems]); }, - onmouseout: id => { + onmouseout: (id: any) => { chart.focus(this.focusItems); } } From 03eb7fdad3a366ac00d14b446adbf9fddd77370e Mon Sep 17 00:00:00 2001 From: Brennan Douglas Date: Sat, 12 Oct 2019 12:24:17 -0700 Subject: [PATCH 2/2] chore(charts): clean up types + arrow functions --- src/components/chart.vue | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/components/chart.vue b/src/components/chart.vue index fbf0f75..319b6bd 100644 --- a/src/components/chart.vue +++ b/src/components/chart.vue @@ -92,7 +92,7 @@ export default Vue.extend({ }, legend: { item: { - onclick: (id: any) => { + onclick: (id: string) => { if (this.focusItems.includes(id)) { this.focusItems = this.focusItems.filter(v => v !== id); } else { @@ -100,12 +100,8 @@ export default Vue.extend({ } chart.focus(this.focusItems); }, - onmouseover: (id: any) => { - chart.focus([id, ...this.focusItems]); - }, - onmouseout: (id: any) => { - chart.focus(this.focusItems); - } + onmouseover: (id: string) => chart.focus([id, ...this.focusItems]), + onmouseout: (id: string) => chart.focus(this.focusItems) } } };