From 6d26a1cd0ed7dabe51f54e4a8648c0317555bc5c Mon Sep 17 00:00:00 2001
From: Drew Malin <dmalin@nvidia.com>
Date: Thu, 4 Sep 2025 11:59:30 -0700
Subject: [PATCH] feat(BREV-1656): Add cloud to instance type

---
 v1/instancetype.go                      | 6 +++---
 v1/providers/fluidstack/instancetype.go | 1 +
 v1/providers/lambdalabs/instancetype.go | 3 ++-
 v1/providers/shadeform/instancetype.go  | 4 ++--
 4 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/v1/instancetype.go b/v1/instancetype.go
index 749ee95e..171907ff 100644
--- a/v1/instancetype.go
+++ b/v1/instancetype.go
@@ -45,7 +45,7 @@ type InstanceType struct {
 	NotPrivileged                   bool
 	EstimatedDeployTime             *time.Duration
 	Provider                        string
-	CloudBroker                     string
+	Cloud                           string
 	CanModifyFirewallRules          bool
 }
 
@@ -74,8 +74,8 @@ func MakeGenericInstanceTypeIDFromInstance(instance Instance) InstanceTypeID {
 type GPU struct {
 	Count          int32
 	Memory         units.Base2Bytes
-	MemoryDetails  string
-	NetworkDetails string
+	MemoryDetails  string // "", "HBM", "GDDR", "DDR", etc.
+	NetworkDetails string // "PCIe", "SXM4", "SXM5", etc.
 	Manufacturer   string
 	Name           string
 	Type           string
diff --git a/v1/providers/fluidstack/instancetype.go b/v1/providers/fluidstack/instancetype.go
index 3a6540d7..4f04bce5 100644
--- a/v1/providers/fluidstack/instancetype.go
+++ b/v1/providers/fluidstack/instancetype.go
@@ -107,5 +107,6 @@ func convertFluidStackInstanceTypeToV1InstanceType(location string, fsInstanceTy
 		IsAvailable:   isAvailable,
 		Location:      location,
 		Provider:      CloudProviderID,
+		Cloud:         CloudProviderID,
 	}
 }
diff --git a/v1/providers/lambdalabs/instancetype.go b/v1/providers/lambdalabs/instancetype.go
index a1091cb7..ecfe7af4 100644
--- a/v1/providers/lambdalabs/instancetype.go
+++ b/v1/providers/lambdalabs/instancetype.go
@@ -196,7 +196,8 @@ func convertLambdaLabsInstanceTypeToV1InstanceType(location string, instType ope
 		Rebootable:               true,
 		IsAvailable:              isAvailable,
 		BasePrice:                &amount,
-		Provider:                 string(CloudProviderID),
+		Provider:                 CloudProviderID,
+		Cloud:                    CloudProviderID,
 	}
 	it.ID = v1.MakeGenericInstanceTypeID(it)
 	return it, nil
diff --git a/v1/providers/shadeform/instancetype.go b/v1/providers/shadeform/instancetype.go
index 09f87300..ad2a76c8 100644
--- a/v1/providers/shadeform/instancetype.go
+++ b/v1/providers/shadeform/instancetype.go
@@ -181,8 +181,8 @@ func (c *ShadeformClient) convertShadeformInstanceTypeToV1InstanceType(shadeform
 			BasePrice:   basePrice,
 			IsAvailable: region.Available,
 			Location:    region.Region,
-			Provider:    string(shadeformInstanceType.Cloud),
-			CloudBroker: CloudProviderID,
+			Provider:    CloudProviderID,
+			Cloud:       string(shadeformInstanceType.Cloud),
 		})
 	}