Skip to content

Commit a Cargo.lock #36

@Joey9801

Description

@Joey9801

If this repo is cloned + built, rustc emits a large number of errors that look like:

error[E0308]: mismatched types
   --> src\renderer\vulkan\vulkan_renderer\mod.rs:606:7
    |
606 |       instance,
    |       ^^^^^^^^ expected struct `ash::instance::Instance`, found a different struct `ash::instance::Instance`
    |
    = note: perhaps two different versions of crate `ash` are being used?

This is because the Cargo.toml in this repo lists ash = "0.30.0" as a dependency, vk-mem 0.2.2 lists ash >= "0.27.1", and there is no Cargo.lock file in this repo. Cargo doesn't know that the two Ash dependencies must be the same, so Ash versions 0.30.0 and 0.31.0 both get included.

I manually fiddled with the generated Cargo.lock to confirm this was the only issue (by editing the entry for vk-mem to lock its Ash to ash 0.30.0). To fix this properly the canonical Cargo.lock file should be added to this repo.

cargo 1.42.0 (86334295e 2020-01-31)
rustc 1.42.0 (b8cedc004 2020-03-09)
Microsoft Windows 10 Pro, Version 10.0.18363 Build 18363

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions