Skip to content

RA __setitem__ for an all-False index should succeed #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justinrporter wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RA __setitem__ for an all-False index should succeed #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
650a580
Contribute failing test for all-false RA indexing.
justinrporter May 8, 2017
9d732c5
Merge branch 'master' into ra-indexing-bug
justinrporter Aug 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions enspara/util/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,16 @@ def test_RaggedArray_setting(self):
assert_equals(a[0, 2], -2)
assert_equals(a[0, -1], -1)

def test_RaggedArray_allfalse_setitem(self):
src = np.array(range(15))
a = ra.RaggedArray(array=src, lengths=[10, 5])

# here, we choose an index that will be all False, and attempt
# to use it in __setitem__
a[a < 0] = -1

assert_ra_equal(a, ra.RaggedArray(src, lengths=a.lengths))

def test_ra_eq(self):
src = [range(10), range(20), range(30)]
a = ra.RaggedArray(array=src)
Expand Down