Adapt the code to new omnet versions

[aarizaq]

I have modified the code to compile with omnet 5.2/5.3
this file has the modifications. You only need to import the project in the IDE. I haven't tested if the examples run, only that the code compiles without errors.

Castalia-master.zip

[boulis]

Mouhamadi has also created a port for OMNeT 5.2 and also conducted some tests to find deviations from Castalia runnig on OMNeT 4.6. His patches, report, and resulting discussion can be found here:
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/castalia-simulator/5LU_xkfNqL8/KYAfHZTuAgAJ

It's worth noting that Mouhamadi's port includes patch files. I find this a more elegant solution for distributing changes to code.
It would be good to study the differences and similarities between the two port efforts.

[aarizaq]

Castalia.zip
This is the port for 5.3,

And yes, my aproach is a bit less elegant, for example instead of include the route to the headers files in the ocde I have used a makefrag file to define the default header route. And my skills with scripts files is a bit lacking, this is the reasion why i prefer to use the whole project.

For omnet 5.3 it is necesary to include some aditional modifications.

[boulis]

Could we merge the two ports into one? (keeping the advantages of each one)
I do not have the time to look into this, but whoever is willing, it could be a valuable service to the Castalia community.

[aarizaq]

Most of the modification cover the problem witht he headers, omnet 5.2 and 5.3 need the route in the header #include "use/xxx/xxx.h", I have tries to modified the code the less possible and I have opted by a makefrag file where the include path variable is defined with the route to the diferent directories. I suppose that this modification is easier for the people that are used to the oldest versions of omnet. The rest of the modifications are basically the same, the change of some methods that have disappeared to the new (for example 'opp_error', not must be 'throw cRuntimeError'). A modification that I have included is the package castalia, this force the changes in the ned files routes to castalia.xxx.xx and in the c++ code when you use the class cTopology, now the nodes use this “castalia.node.Node” instead of “node.Node”. Other change that I have included that it is necessary for 5.3 is if read a configuration paramater in the c++ code, for example ‘int foo = par(“foo”);’, foo must be declared in the ned file like integer, if the types doesn’t coincide the simulator will raise an error. I have force casting in the code in some parts to avoid this problem for example ‘double foo = (int)par(“foo”);’.

I have also
PD : I have solved a couple of errors that are raised by the compiler clang.

In the file Basic802154.cc, the code has
if (seqNum > 255) seqNum == 0;
This doesn’t have sense, I have replaced to
if (seqNum > 255) seqNum = 0;

Have modified
packet BypassRoutingPacket extends RoutingPacket {
string source;
string destination;
}
to
packet BypassRoutingPacket extends RoutingPacket {
}

message RadioControlCommand {
int radioControlCommandKind enum (RadioControlCommand_type);
int state enum (BasicState_type) = RX; //to be used with SET_STATE
double parameter = 0.0; //to be used with SET_TX_OUTPUT, SET_CARRIER_FREQ, SET_CCA_THRESHOLD
string name = ""; //to be used with SET_MODE, SET_SLEEP_LEVEL and SET_ENCODING
}
To
message RadioControlCommand {
int radioControlCommandKind enum (RadioControlCommand_type);
int state enum (BasicState_type) = RX; //to be used with SET_STATE
double parameter = 0.0; //to be used with SET_TX_OUTPUT, SET_CARRIER_FREQ, SET_CCA_THRESHOLD
}

The file includes the .project and .cproject files to import it directly in the omnet IDE, I suppose that to load the project directly in the IDE is simpler for the new user that to use the command line options.

[aarizaq]

Now the makemake also works (tested in windows 10). With this version you can use the scrips or to use the IDE, this simplify the debug.
Castalia.zip

And sorry for the misspellings, I am ashamed when I have read that I have written

[aarizaq]

My latest modification, this include modifications in the Castalia.py that allows to run the srtipt in windows. The root Makefile has been completly rewrite and the makemake file is now a call to the Makefile.
I can now run castalia from the command line or from the IDE in windows using omnet 5.3p3
Castalia.zip

[xarokk]

Thanks , very useful.

[Hana33]

Is this solution functional on ubuntu too ? Would you please mention exactly which folder in the discussion is the one that I have to import into the IDE to adapt castalia with omnet 5.3 (on ubuntu) ? My questions sound maybe kind of clumsy , I am still a newbie
Thank you for your help;

[aarizaq]

It should work in ubuntu also

[Hana33]

I have compiled the modified version of Castalia on Omnet 5.3 and everything goes well; But when trying to run my first simulation using command line as in the manual /Castalia/Simulations/radioTest$ ../../bin/Castalia -c General
I got this error:
bash: ../../bin/Castalia : Permission denied

Have anyone tested if the examples run in this case ?

[aarizaq]

Linux or windows, if you are working in Linux you need to check if the file Castalia (case sensitive) exist and the permit (with ls –l). If you are working in omnet 5.3 is possible that you have created the program in debug mode and in this case the file is called Castalia_dbg. De: Hana33 [mailto:notifications@github.com] Enviado el: domingo, 22 de julio de 2018 21:28 Para: boulis/Castalia <Castalia@noreply.github.com> CC: Alfonso <aarizaq_m@hotmail.com>; Author <author@noreply.github.com> Asunto: Re: [boulis/Castalia] Adapt the code to new omnet versions (#12) I have compiled the modified version of Castalia on Omnet 5.3 and everything goes well; But when trying to run my first simulation using command line as in the manual /Castalia/Simulations/radioTest$ ../../bin/Castalia -c General I got this error: bash: ../../bin/Castalia : Permission denied Have anyone tested if the examples run in this case ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#12 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AADyd1ydOE8fmzB7pRsfbheX9uQzMeeXks5uJNJagaJpZM4Sq7-N>.

[Hana33]

I didn't get exactly what do you mean ? I am working on ubuntu 16.4 and there is no such file as Castalia_dbg. I even added the path to .bashrc and .profile
export PATH=$PATH:/home/usr/../Castalia/bin
but still got the same error
Could you please explain me more

[aarizaq]

Check the route “/home/usr/../Castalia/bin” This search in the directory /home/Castalia De: Hana33 [mailto:notifications@github.com] Enviado el: lunes, 23 de julio de 2018 10:44 Para: boulis/Castalia <Castalia@noreply.github.com> CC: Alfonso <aarizaq_m@hotmail.com>; Author <author@noreply.github.com> Asunto: Re: [boulis/Castalia] Adapt the code to new omnet versions (#12) I didn't get exactly what do you mean ? I am working on ubuntu 16.4 and there is no such file as Castalia_dbg. I even added the path to .bashrc and .profile export PATH=$PATH:/home/usr/../Castalia/bin but still got the same error Could you please explain me more — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#12 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AADyd2Nf6TjJcETAxgT0zVf4wThUOMHeks5uJYzOgaJpZM4Sq7-N>.

[Hana33]

Checked, I have only these four files in the folder Castalia/bin (screen capture joint) Castalia CastaliaPlot CastaliaResults extractOmnetppINI Le lun. 23 juil. 2018 à 11:07, Alfonso <notifications@github.com> a écrit :

…

Check the route “/home/usr/../Castalia/bin” This search in the directory /home/Castalia De: Hana33 ***@***.*** Enviado el: lunes, 23 de julio de 2018 10:44 Para: boulis/Castalia ***@***.***> CC: Alfonso ***@***.***>; Author ***@***.***> Asunto: Re: [boulis/Castalia] Adapt the code to new omnet versions (#12) I didn't get exactly what do you mean ? I am working on ubuntu 16.4 and there is no such file as Castalia_dbg. I even added the path to .bashrc and .profile export PATH=$PATH:/home/usr/../Castalia/bin but still got the same error Could you please explain me more — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< #12 (comment)>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AADyd2Nf6TjJcETAxgT0zVf4wThUOMHeks5uJYzOgaJpZM4Sq7-N>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AmSaauXLz1nqG4ZIxtvrPoXiBqhix8T_ks5uJZJcgaJpZM4Sq7-N> .

-- *Hana RHIM * *PhD Student in TIC **(Sup'Com)* *Xlim Laboratory Limoges*

[Hana33]

It is Okey, I have solved the problem.

I added the word python as : /Castalia/Simulations/radioTest$ python ../../bin/Castalia -c General and it works !
another radical solution is to allow all permissions to the file ../bin/Castalia by setting chmod 777 Castalia as a command line and then type the usual ../../bin/Castalia -c General