Skip to content

Ensure NRVO is done through the Deserializer to avoid memory corruption #691

@Geod24

Description

@Geod24

We plan to expand the usage of the serializer to be used for network communication.
Currently we are using the less-than-ideal JSON approach, which adds a lot of overhead.
However, due to concerns about efficiency and internal pointers (e.g. std::string), the deserializer should not perform any unwarranted move.

DoD:

  • There is an utility that test if a type is moving during deserialization;
  • Tests are added so that SCPEnvelope is not moved;

Metadata

Metadata

Assignees

Labels

C.GeneralAn issue which doesn't fit in the other categories (not blockchain related)Story-Points:8This takes 5 to 7 days to completetype-testingFor issues which relate to test scenarios

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions