Fix/azure continuation token cursor #1592
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix type error caused by stricter type checking in @types/node 20.19.x where RequestOptions.headers could be OutgoingHttpHeaders or readonly string array. Added explicit type cast to OutgoingHttpHeaders when setting Content-Length header. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…tokens
This fix addresses the cursor position tracking issue when using Cosmos DB's
native continuation token pagination. Previously, the cursor.id on the last
page would only show the page count instead of the cumulative total.
Changes:
- Track cumulative offset across pagination requests with continuation tokens
- Store both continuationToken and cumulative id in cursor object
- Ensure last page cursor reflects total records processed, not just page size
- Add comprehensive debug logging for cursor tracking
Example: For 268 total records with limit 200:
- Page 1: Returns 200 records → cursor: { continuationToken: "...", id: "200" }
- Page 2: Returns 68 records → cursor: { id: "268" } (previously was "68")
This maintains backward compatibility with legacy offset-based pagination
while fixing the continuation token cursor tracking.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Restore workspace: protocol for internal package references in framework-provider-azure to maintain consistency with monorepo structure. Changes: - @boostercloud/framework-common-helpers: workspace:^3.4.3 - @boostercloud/framework-types: workspace:^3.4.3 - @boostercloud/eslint-config: workspace:^3.4.3 - Update pnpm-lock.yaml 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
PR Summary
|
Contributor
|
Oops, looks like you forgot to add a changeset.
This command will prompt you for a change description and generate a changeset file. You can read more about changesets here. Remember that you should use the version bump that is appropriate for the change you are making:
If you are unsure about which version bump to use, please ask in the comments and we will help you out. |
Collaborator
Author
|
/integration sha=276d470 |
Contributor
|
⌛ Integration tests are running... Check their status here 👈 |
Contributor
|
❌ Oh no! Integration tests have failed |
Update integration test to expect both continuationToken and cumulative id fields in cursor object, reflecting the fix for cursor position tracking. The new cursor format for continuation token pagination now includes: - continuationToken: Cosmos DB's native continuation token - id: Cumulative position counter for tracking total records processed This ensures the cursor accurately represents position across paginated results while maintaining backward compatibility with legacy offset-based pagination. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Collaborator
Author
|
/integration sha=e824d33f |
Contributor
|
⌛ Integration tests are running... Check their status here 👈 |
Contributor
|
✅ Integration tests have finished successfully! |
Azure Cosmos DB requires: - maxItemCount must be set when using continuation tokens - LIMIT must be used when using OFFSET in queries Without these, the SDK throws "one of the input values is invalid" error. This fix defaults both to 100 when no limit is provided, ensuring: - OFFSET is always paired with LIMIT (legacy cursor path) - continuationToken is always paired with maxItemCount (continuation token path) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Collaborator
Author
|
/integration sha=e5260b14c42abadcce55a3e3222f5dd2a5b3f1fe |
Contributor
|
⌛ Integration tests are running... Check their status here 👈 |
Contributor
|
✅ Integration tests have finished successfully! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Checks