fix(ci): improve version handling in publish workflow

- Simplify environment variable setting using Add-Content

- Add version normalization step to sanitize special characters

- Pass version parameters to publish commands for proper assembly versioning

Author: boexler

.github/workflows/commit.yml

@@ -48,15 +48,23 @@ jobs:
       id: gitversion
       run: |
         $version = dotnet-gitversion /showvariable FullSemVer
-        Write-Host "VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8
-        Write-Host "version=$version" | Out-File -FilePath $env:GITHUB_OUTPUT -Append -Encoding utf8
+        Add-Content $env:GITHUB_ENV "VERSION=$version"
+        Add-Content $env:GITHUB_OUTPUT "version=$version"
+    - name: Normalize version
+      run: |
+        $rawVersion = $env:VERSION
+        $safeVersion = $rawVersion -replace '[^a-zA-Z0-9\.\-]', '_'
+        Add-Content $env:GITHUB_ENV "SAFE_VERSION=$safeVersion"
     - name: Publish Self-Contained
       run: |
         dotnet publish app/Sentinel.NLogViewer.App/Sentinel.NLogViewer.App.csproj `
           -c Release `
           -p:SelfContained=true `
           -p:PublishSingleFile=true `
           -p:RuntimeIdentifier=win-x64 `
+          -p:Version=$env:VERSION `
+          -p:AssemblyVersion=$env:VERSION `
+          -p:FileVersion=$env:VERSION `
           -p:IncludeNativeLibrariesForSelfExtract=true `
           -o publish/self-contained
     - name: Publish Framework-Dependent
@@ -65,23 +73,26 @@ jobs:
           -c Release `
           -p:SelfContained=false `
           -p:RuntimeIdentifier=win-x64 `
+          -p:Version=$env:VERSION `
+          -p:AssemblyVersion=$env:VERSION `
+          -p:FileVersion=$env:VERSION `
           -o publish/framework-dependent
     - name: Rename folders with version
       run: |
-        $version = $env:VERSION
+        $version = $env:SAFE_VERSION
         Rename-Item -Path "publish/self-contained" -NewName "NLogViewer-SelfContained-win-x64-$version"
         Rename-Item -Path "publish/framework-dependent" -NewName "NLogViewer-FrameworkDependent-win-x64-$version"
     - name: Upload Self-Contained artifact
       uses: actions/upload-artifact@v4
       with:
-        name: NLogViewer-SelfContained-win-x64-${{ env.VERSION }}
-        path: publish/NLogViewer-SelfContained-win-x64-${{ env.VERSION }}
+        name: NLogViewer-SelfContained-win-x64-${{ env.SAFE_VERSION }}
+        path: publish/NLogViewer-SelfContained-win-x64-${{ env.SAFE_VERSION }}
         if-no-files-found: error
         retention-days: 1
     - name: Upload Framework-Dependent artifact
       uses: actions/upload-artifact@v4
       with:
-        name: NLogViewer-FrameworkDependent-win-x64-${{ env.VERSION }}
-        path: publish/NLogViewer-FrameworkDependent-win-x64-${{ env.VERSION }}
+        name: NLogViewer-FrameworkDependent-win-x64-${{ env.SAFE_VERSION }}
+        path: publish/NLogViewer-FrameworkDependent-win-x64-${{ env.SAFE_VERSION }}
         if-no-files-found: error
         retention-days: 1