From 489e13b0cc5d5e2864019f122088ad10aac84248 Mon Sep 17 00:00:00 2001 From: Roel van Hintum Date: Thu, 21 Sep 2017 09:58:05 +0200 Subject: [PATCH 1/2] elementvars is optional for users when no group is selected. --- services/Export_UserService.php | 4 +- templates/_map.twig | 99 +++++++++++++++++---------------- 2 files changed, 54 insertions(+), 49 deletions(-) diff --git a/services/Export_UserService.php b/services/Export_UserService.php index 99b0c0d..94cab93 100644 --- a/services/Export_UserService.php +++ b/services/Export_UserService.php @@ -116,7 +116,9 @@ public function setCriteria(array $settings) $criteria->status = isset($settings['map']['status']) ? $settings['map']['status'] : null; // Get by group - $criteria->groupId = $settings['elementvars']['groups']; + if (isset($settings['elementvars']) && isset($settings['elementvars']['groups'])) { + $criteria->groupId = $settings['elementvars']['groups']; + } return $criteria; } diff --git a/templates/_map.twig b/templates/_map.twig index 2b07a67..ee5416b 100644 --- a/templates/_map.twig +++ b/templates/_map.twig @@ -16,59 +16,62 @@ {% endfor %} - {% for key, value in export.elementvars %} - {% if value is iterable %} - {% for subvalue in value %} - - {% endfor %} - {% else %} - - {% endif %} - {% endfor %} + {% if export.elementvars is defined %} + {% for key, value in export.elementvars %} + {% if value is iterable %} + {% for subvalue in value %} + + {% endfor %} + {% else %} + + {% endif %} + {% endfor %} + {% endif %}

{{ "Choose which fields you want to export."|t }}

- {% set fields = craft.export.getFields(export.type, reset) %} - {% for handle, data in fields %} - {% if data.fieldtype is defined %} - {% set customTableRow = craft.export.customTableRow(data.fieldtype) %} - {% else %} - {% set customTableRow = false %} - {% endif %} - {% if customTableRow %} - {% include customTableRow ignore missing %} - {% else %} - - - - - - {% endif %} - {% endfor %} + {% set fields = craft.export.getFields(export.type, reset) %} + {% for handle, data in fields %} + {% if data.fieldtype is defined %} + {% set customTableRow = craft.export.customTableRow(data.fieldtype) %} + {% else %} + {% set customTableRow = false %} + {% endif %} + + {% if customTableRow %} + {% include customTableRow ignore missing %} + {% else %} + + + + + + {% endif %} + {% endfor %} From b7c982d6d689cfb10bc0205f8db8d390ee8eb013 Mon Sep 17 00:00:00 2001 From: Roel van Hintum Date: Wed, 25 Oct 2017 10:13:36 +0200 Subject: [PATCH 2/2] Make sure to remove line-breaks from text fields. --- services/ExportService.php | 1 + 1 file changed, 1 insertion(+) diff --git a/services/ExportService.php b/services/ExportService.php index 064dc5a..96b8b3b 100644 --- a/services/ExportService.php +++ b/services/ExportService.php @@ -449,6 +449,7 @@ public function parseFieldData($handle, $data) case ExportModel::FieldTypeDropdown: // Resolve to string $data = (string) $data; + $data = preg_replace('/\r|\n/', '', $data); break; case ExportModel::FieldTypeCheckboxes:
-
-
- - - {% if data.entrytype is defined %}{% endif %} -
-
-
-
-
- - -
-
-
- {{ forms.checkboxField({ - label: 'Include in export'|t, - instructions: "This value will be included in the export file."|t, - name: "fields[" ~ handle ~ "][checked]", - checked: data.checked - }) }} -
+
+
+ + + {% if data.entrytype is defined %}{% endif %} +
+
+
+
+
+ + +
+
+
+ {{ forms.checkboxField({ + label: 'Include in export'|t, + instructions: "This value will be included in the export file."|t, + name: "fields[" ~ handle ~ "][checked]", + checked: data.checked + }) }} +