hci_dump_t: could use const uint8_t * packet in all implementations

[ua1arn]

Some compile warnings then use debugging features.
I propose these fixes:

[mringwal]

Hi. In which setup did you get compiler warnings? Could you paste them here?

If I change the pointer to packet in hci_dump_packet to const, I get an error calling hci_dump_implementation->log_packet(..) as it expects a non-const packet. (this could be fixed as well, but requires changes to all hci_dump_implementations...)

I've added the (unsigned) cast in rfcomm.c on develop.

[ua1arn]

arm-none-eabi-gcc -o o/lib/btstack/src/hci_dump.o -std=gnu99 -Wstrict-prototypes -c -mcpu=cortex-a53 -mfloat-abi=hard -mfpu=neon-vfpv4 --specs=nosys.specs -fno-math-errno -funroll-loops -fgraphite-identity -ffunction-sections -fdata-sections -ffat-lto-objects -ftree-vectorize -Ofast -gdwarf-2 -fomit-frame-pointer -Wall  -D"NDEBUG"=1 -D"CPUSTYLE_T507"=1 -D"CPUSTYLE_CA53"=1  -MD -MP -MF ./o/lib/btstack/src/hci_dump.o.d -I../../arch/aw_t507 -I../../src/hal -I../../CMSIS_6/CMSIS/Core/Include -I../../CMSIS_6/CMSIS/Core/Source -I../../CMSIS-DSP/Include -I../../CMSIS-DSP/ComputeLibrary/Include -I../../CMSIS-DSP/Source -I../../CMSIS-DSP/PrivateInclude -I../../lib/Middlewares/ST/STM32_USB_Device_Library/Core/Inc -I../../lib/hftrx_tinyusb/src -I../.. -I../../inc -I../../lib/btstack/src/ble -I../../lib/btstack/src/ble/gatt-service -I../../lib/btstack/src/classic -I../../lib/btstack/src -I../../lib/btstack/3rd-party/micro-ecc -I../../lib/btstack/3rd-party/bluedroid/decoder/include -I../../lib/btstack/3rd-party/bluedroid/encoder/include -I../../lib/btstack/3rd-party/hxcmod-player -I../../lib/btstack/3rd-party/hxcmod-player/mods -I../../lib/btstack/3rd-party/md5 -I../../lib/btstack/3rd-party/yxml -I../../lib/btstack/3rd-party/segger-rtt -I../../lib/btstack/platform/embedded -I../../lib/btstack/platform/lwip -I../../lib/btstack/platform/lwip/port ../../lib/btstack/src/hci_dump.c
../../lib/btstack/src/hci_dump.c: In function 'hci_dump_btstack_event':
../../lib/btstack/src/hci_dump.c:121:42: warning: passing argument 3 of 'hci_dump_packet' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  121 |     hci_dump_packet(HCI_EVENT_PACKET, 1, packet, len);
      |                                          ^~~~~~
../../lib/btstack/src/hci_dump.c:81:64: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'const uint8_t *' {aka 'const unsigned char *'}
   81 | void hci_dump_packet(uint8_t packet_type, uint8_t in, uint8_t *packet, uint16_t len) {
      |                                                       ~~~~~~~~~^~~~~~

Bare-metal SDR project on Allwinner T507-H in this case

[ua1arn]

his could be fixed as well, but requires changes to all hci_dump_implementations...
You right... this also needed...

[ua1arn]

#define ENABLE_LOG_ERROR
#define ENABLE_LOG_BTSTACK_EVENTS
#define ENABLE_PRINTF_HEXDUMP