-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: codex subscription support #6600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for ChatGPT Codex subscriptions (ie. ChatGPT Plus/Pro) through OAuth authentication, allowing users to access GPT-5 Codex models using their existing ChatGPT subscription.
Changes:
- New
ChatGptCodexProviderwith OAuth PKCE flow implementation for authentication - Backend API endpoint
/config/providers/{name}/oauthfor triggering OAuth flows - UI updates to support OAuth provider configuration with a sign-in button instead of manual API key entry
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/goose/src/providers/chatgpt_codex.rs | Complete new provider implementation with OAuth PKCE flow, token management, and Codex API integration |
| crates/goose/src/providers/mod.rs | Added chatgpt_codex module export |
| crates/goose/src/providers/factory.rs | Registered ChatGptCodexProvider in the provider registry |
| crates/goose-server/src/routes/config_management.rs | Added configure_provider_oauth endpoint to trigger OAuth flows |
| crates/goose-server/src/openapi.rs | Added configure_provider_oauth to OpenAPI documentation |
| ui/desktop/openapi.json | Auto-generated OpenAPI schema for the new OAuth endpoint |
| ui/desktop/src/api/types.gen.ts | Auto-generated TypeScript types for OAuth endpoint |
| ui/desktop/src/api/sdk.gen.ts | Auto-generated SDK function for OAuth endpoint |
| ui/desktop/src/api/index.ts | Auto-generated exports for OAuth endpoint |
| ui/desktop/src/components/settings/providers/modal/ProviderConfiguationModal.tsx | Added OAuth flow UI with sign-in button and loading states |
ui/desktop/src/components/settings/providers/modal/ProviderConfiguationModal.tsx
Outdated
Show resolved
Hide resolved
* main: increase worker threads for ci (#6614) docs: todo tutorial update (#6613) Added goose doc map md file for goose agent to find relevant doc easily. (#6598) add back goose branding to home (#6617) fix: actually set the working dir for extensions from session (#6612) Multi chat (#6428) Lifei/fixed accumulated token count (#6587) Dont show MCP UI/Apps until tool is approved (#6492)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 12 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
|
just to ack.. I am on this one |
|
pushed some cleanups e.g. that singleton stuff feels more like sessionmanager and permissions manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 12 comments.
ui/desktop/src/components/settings/providers/modal/ProviderConfiguationModal.tsx
Outdated
Show resolved
Hide resolved
codefromthecrypt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked at the code and tidied up certain things that stood out. If this works for you after my changes, mergeroo
This lets goose work with codex subscriptions:
Will use system browser to auth to use the subscription: