Recording env vars can leak on new test failure

[MacMcIrish]

While recording a new test that failed, the env vars set in envVarYmlRecording were used in subsequent tests rather than the env vars in envVarYml

[simlu]

Not sure I understand. Can you clarify? I'd say it's expected behaviour?

[MacMcIrish]

The env vars in envVarYmlRecording were used in tests that already have recordings after the test failure, the suite was as follows

1. Existing recording -> used envVarYml ✔️
2. No existing recording -> used envVarYmlRecording ❌
3. Existing recording -> used envVarYmlRecording ❌ (nock mismatch because wrong env vars used)

[simlu]

That makes sense. The test fails and the cleanup isn't triggered as expected. Not sure how to best fix that...

[simlu]

I would think this is fixed with the new test failure handling. Could you confirm please?