project updates/cleanup

Author: apple1417

.cruft.json

@@ -1,6 +1,6 @@
 {
   "template": "git@github.com:bl-sdk/common_dotfiles.git",
-  "commit": "597ec422d3b5692927f325b9b5c2ae42288e8cc5",
+  "commit": "91563903c1b88e5cc2363d448e62180fdb318382",
   "checkout": null,
   "context": {
     "cookiecutter": {
@@ -15,7 +15,8 @@
       "__project_slug": "pluginloader",
       "include_cpp": true,
       "include_py": false,
-      "_template": "git@github.com:bl-sdk/common_dotfiles.git"
+      "_template": "git@github.com:bl-sdk/common_dotfiles.git",
+      "_commit": "91563903c1b88e5cc2363d448e62180fdb318382"
     }
   },
   "directory": null

.gitignore

@@ -1,6 +1,7 @@
 .vs
 .vscode
 .idea
+.nvim.lua
 
 # C/C++ excludes
 .cache/clangd

CMakePresets.json

@@ -1,4 +1,4 @@
-{
+{
   "version": 3,
   "configurePresets": [
     {

common_cmake

@@ -16,9 +16,11 @@ void create_if_needed(void) {
     SetConsoleTitleA("Plugin Loader Debug Console");
 
     // All of this is necessary so that way we can properly use the output of the console
+    // NOLINTBEGIN(misc-const-correctness) - clang tidy 21.1.x false positive
     FILE* new_stdin = nullptr;
     FILE* new_stdout = nullptr;
     FILE* new_stderr = nullptr;
+    // NOLINTEND(misc-const-correctness)
     freopen_s(&new_stdin, "CONIN$", "r", stdin);
     freopen_s(&new_stdout, "CONOUT$", "w", stdout);
     freopen_s(&new_stderr, "CONOUT$", "w", stderr);

src/console.cpp

@@ -20,11 +20,11 @@ FARPROC d3d11_on_12_create_device_ptr = nullptr;
 
 // NOLINTBEGIN(readability-identifier-naming, readability-identifier-length)
 
-#if defined(__MINGW32__)
+#ifdef __MINGW32__
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wcast-function-type"
 #endif
-#if defined(__clang__)
+#ifdef __clang__
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-function-type-mismatch"
 #endif
@@ -85,10 +85,10 @@ DLL_EXPORT HRESULT D3D11On12CreateDevice(void* pDevice,
         ppDevice, ppImmediateContext, pChosenFeatureLevel);
 }
 
-#if defined(__clang__)
+#ifdef __clang__
 #pragma clang diagnostic pop
 #endif
-#if defined(__MINGW32__)
+#ifdef __MINGW32__
 #pragma GCC diagnostic pop
 #endif
 

src/proxy/d3d11.cpp

@@ -26,11 +26,11 @@ FARPROC direct_sound_capture_create_8_ptr = nullptr;
 
 // NOLINTBEGIN(readability-identifier-naming)
 
-#if defined(__MINGW32__)
+#ifdef __MINGW32__
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wcast-function-type"
 #endif
-#if defined(__clang__)
+#ifdef __clang__
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-function-type-mismatch"
 #endif
@@ -110,10 +110,10 @@ DLL_EXPORT HRESULT WINAPI DirectSoundCaptureCreate8(LPCGUID pcGuidDevice,
         direct_sound_capture_create_8_ptr)(pcGuidDevice, ppDSC8, pUnkOuter);
 }
 
-#if defined(__clang__)
+#ifdef __clang__
 #pragma clang diagnostic pop
 #endif
-#if defined(__MINGW32__)
+#ifdef __MINGW32__
 #pragma GCC diagnostic pop
 #endif
 

src/proxy/dsound.cpp

@@ -30,11 +30,11 @@ FARPROC xinput_power_off_controller_ptr = nullptr;
 
 // NOLINTBEGIN(readability-identifier-naming)
 
-#if defined(__MINGW32__)
+#ifdef __MINGW32__
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wcast-function-type"
 #endif
-#if defined(__clang__)
+#ifdef __clang__
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-function-type-mismatch"
 #endif
@@ -97,10 +97,10 @@ DLL_EXPORT DWORD XInputPowerOffController(DWORD dwUserIndex) {
         dwUserIndex);
 }
 
-#if defined(__clang__)
+#ifdef __clang__
 #pragma clang diagnostic pop
 #endif
-#if defined(__MINGW32__)
+#ifdef __MINGW32__
 #pragma GCC diagnostic pop
 #endif