Skip to content

Showcase mode does not behave correctly #7

@zaventh

Description

@zaventh

Version 0.7.0

Consider the following:

<NftGallery darkMode hasExternalLinks={false} showcaseMode
                                showcaseItemIds={[
                                    '0x148d1280a62ef720124537cdf53a084d499607e4/6',
                                    '0x148d1280a62ef720124537cdf53a084d499607e4/7',
                                ]}
                                ownerAddress="knitkins.eth"/>

What I expected to happen was for an XHR to OpenSea to gather the first 20 items from the ownerAddress and then filter those results for the defined showcaseItemIds and display two images.

What actually happens is the component makes 20 XHR requests to OpenSea and each time renders the two items twice. The result is a total of 40 images (20x2) displayed. If I add another showcaseItemIds to have say three total, then 40 requests to OpenSea are made and 90 images (30x3) are displayed.

Screenshot from 2022-04-11 14-38-00

Using the component in non-showcase mode behaves correctly and displays the most recent 20 results from OS (not using an API key currently).

I can provide additional details if necessary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions