fix(test): use new Persister type

rustaceanrob · rustaceanrob · commit 66eab407d6cb · 2025-06-02T14:04:51.000+01:00
Changes named arguments in Swift as well as constructing the new
`Persist` type with the usual sqlite database
diff --git a/bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/LiveTxBuilderTest.kt b/bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/LiveTxBuilderTest.kt
@@ -27,7 +27,7 @@ class LiveTxBuilderTest {
 
     @Test
     fun testTxBuilder() {
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, conn)
         val esploraClient: EsploraClient = EsploraClient(SIGNET_ESPLORA_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
@@ -51,7 +51,7 @@ class LiveTxBuilderTest {
 
     @Test
     fun complexTxBuilder() {
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, conn)
         val esploraClient: EsploraClient = EsploraClient(SIGNET_ESPLORA_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
diff --git a/bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/LiveWalletTest.kt b/bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/LiveWalletTest.kt
@@ -28,7 +28,7 @@ class LiveWalletTest {
 
     @Test
     fun testSyncedBalance() {
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet: Wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, conn)
         val esploraClient: EsploraClient = EsploraClient(SIGNET_ESPLORA_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
@@ -54,7 +54,7 @@ class LiveWalletTest {
 
     @Test
     fun testBroadcastTransaction() {
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, conn)
         val esploraClient = EsploraClient(SIGNET_ESPLORA_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
diff --git a/bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/OfflineWalletTest.kt b/bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/OfflineWalletTest.kt
@@ -36,7 +36,7 @@ class OfflineWalletTest {
 
    @Test
     fun testNewAddress() {
-        val conn = Connection.newInMemory()
+        val conn = Persister.newInMemory()
         val wallet: Wallet = Wallet(
             descriptor,
             changeDescriptor,
@@ -58,7 +58,7 @@ class OfflineWalletTest {
 
     @Test
     fun testBalance() {
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet: Wallet = Wallet(
             descriptor,
             changeDescriptor,
diff --git a/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveElectrumClientTest.kt b/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveElectrumClientTest.kt
@@ -18,7 +18,7 @@ class LiveElectrumClientTest {
 
     @Test
     fun testSyncedBalance() {
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet: Wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, conn)
         val electrumClient: ElectrumClient = ElectrumClient(SIGNET_ELECTRUM_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
diff --git a/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveKyotoTest.kt b/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveKyotoTest.kt
@@ -28,7 +28,7 @@ class LiveKyotoTest {
 
     @Test
     fun testKyoto() {
-        val conn: Connection = Connection.newInMemory()
+        val conn: Persister = Persister.newInMemory()
         val wallet: Wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, conn)
         val peers = listOf(peer)
         runBlocking {
diff --git a/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveMemoryWalletTest.kt b/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveMemoryWalletTest.kt
@@ -21,7 +21,7 @@ class LiveMemoryWalletTest {
             "wpkh(tprv8ZgxMBicQKsPf2qfrEygW6fdYseJDDrVnDv26PH5BHdvSuG6ecCbHqLVof9yZcMoM31z9ur3tTYbSnr1WBqbGX97CbXcmp5H6qeMpyvx35B/84h/1h/1h/0/*)",
             Network.SIGNET
         )
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet: Wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, conn)
         val esploraClient: EsploraClient = EsploraClient(SIGNET_ESPLORA_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
@@ -45,7 +45,7 @@ class LiveMemoryWalletTest {
 
     @Test
     fun testScriptInspector() {
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet: Wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, conn)
         val esploraClient: EsploraClient = EsploraClient(SIGNET_ESPLORA_URL)
 
diff --git a/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveTransactionTest.kt b/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveTransactionTest.kt
@@ -17,7 +17,7 @@ class LiveTransactionTest {
 
     @Test
     fun testSyncedBalance() {
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet: Wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, conn)
         val esploraClient: EsploraClient = EsploraClient(SIGNET_ESPLORA_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
diff --git a/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveTxBuilderTest.kt b/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveTxBuilderTest.kt
@@ -32,7 +32,7 @@ class LiveTxBuilderTest {
 
     @Test
     fun testTxBuilder() {
-        val connection: Connection = Connection(persistenceFilePath)
+        val connection: Persister = Persister(persistenceFilePath)
         val wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, connection)
         val esploraClient = EsploraClient(SIGNET_ESPLORA_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
@@ -58,7 +58,7 @@ class LiveTxBuilderTest {
 
     @Test
     fun complexTxBuilder() {
-        val connection: Connection = Connection(persistenceFilePath)
+        val connection: Persister = Persister(persistenceFilePath)
         val wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, connection)
         val esploraClient = EsploraClient(SIGNET_ESPLORA_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
diff --git a/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveWalletTest.kt b/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/LiveWalletTest.kt
@@ -32,7 +32,7 @@ class LiveWalletTest {
 
     @Test
     fun testSyncedBalance() {
-        val connection = Connection(persistenceFilePath)
+        val connection = Persister.newSqlite(persistenceFilePath)
         val wallet: Wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, connection)
         val esploraClient: EsploraClient = EsploraClient(SIGNET_ESPLORA_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
@@ -57,7 +57,7 @@ class LiveWalletTest {
 
     @Test
     fun testBroadcastTransaction() {
-        val connection = Connection(persistenceFilePath)
+        val connection = Persister.newSqlite(persistenceFilePath)
         val wallet: Wallet = Wallet(descriptor, changeDescriptor, Network.SIGNET, connection)
         val esploraClient = EsploraClient(SIGNET_ESPLORA_URL)
         val fullScanRequest: FullScanRequest = wallet.startFullScan().build()
diff --git a/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/OfflinePersistenceTest.kt b/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/OfflinePersistenceTest.kt
@@ -20,7 +20,7 @@ class OfflinePersistenceTest {
 
     @Test
     fun testPersistence() {
-        val connection = Connection(persistenceFilePath)
+        val connection = Persister.newSqlite(persistenceFilePath)
 
         val wallet: Wallet = Wallet.load(
             descriptor,
@@ -42,7 +42,7 @@ class OfflinePersistenceTest {
 
     @Test
     fun testPersistenceWithDescriptor() {
-        val connection = Connection(persistenceFilePath)
+        val connection = Persister.newSqlite(persistenceFilePath)
 
         val descriptorPub = Descriptor(
             "wpkh([9122d9e0/84'/1'/0']tpubDCYVtmaSaDzTxcgvoP5AHZNbZKZzrvoNH9KARep88vESc6MxRqAp4LmePc2eeGX6XUxBcdhAmkthWTDqygPz2wLAyHWisD299Lkdrj5egY6/0/*)#zpaanzgu",
diff --git a/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/OfflineWalletTest.kt b/bdk-jvm/lib/src/test/kotlin/org/bitcoindevkit/OfflineWalletTest.kt
@@ -28,7 +28,7 @@ class OfflineWalletTest {
 
    @Test
    fun testNewAddress() {
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet: Wallet = Wallet(
             descriptor,
             changeDescriptor,
@@ -50,7 +50,7 @@ class OfflineWalletTest {
 
     @Test
     fun testBalance() {
-        var conn: Connection = Connection.newInMemory()
+        var conn: Persister = Persister.newInMemory()
         val wallet: Wallet = Wallet(
             descriptor,
             changeDescriptor,
diff --git a/bdk-python/tests/test_live_kyoto.py b/bdk-python/tests/test_live_kyoto.py
@@ -1,4 +1,4 @@
-from bdkpython import Connection, Network, Descriptor, KeychainKind, CbfBuilder, CbfComponents, CbfClient, CbfNode, CbfError, IpAddress, ScanType, Peer, Update, Wallet
+from bdkpython import Persister, Network, Descriptor, KeychainKind, CbfBuilder, CbfComponents, CbfClient, CbfNode, CbfError, IpAddress, ScanType, Peer, Update, Wallet
 import unittest
 import os
 import asyncio
@@ -28,12 +28,12 @@ def tearDown(self) -> None:
             os.remove("./data/signet/peers.db")
 
     async def testKyoto(self) -> None:
-        connection: Connection = Connection.new_in_memory()
+        persister: Persister = Persister.new_in_memory()
         wallet: Wallet = Wallet(
             descriptor,
             change_descriptor,
             network,
-            connection
+            persister
         )
         peers = [peer]
         light_client: CbfComponents = CbfBuilder().scan_type(ScanType.NEW()).peers(peers).connections(1).build(wallet)
diff --git a/bdk-python/tests/test_live_tx_builder.py b/bdk-python/tests/test_live_tx_builder.py
@@ -7,7 +7,7 @@
 from bdkpython import Address
 from bdkpython import Psbt
 from bdkpython import TxBuilder
-from bdkpython import Connection
+from bdkpython import Persister
 from bdkpython import Network
 from bdkpython import Amount
 from bdkpython import FeeRate
@@ -34,7 +34,7 @@ def tearDown(self) -> None:
             os.remove("./bdk_persistence.sqlite")
 
     def test_tx_builder(self):
-        connection: Connection = Connection.new_in_memory()
+        connection: Persister = Persister.new_in_memory()
         wallet: Wallet = Wallet(
             descriptor,
             change_descriptor,
@@ -66,12 +66,12 @@ def test_tx_builder(self):
         self.assertTrue(psbt.serialize().startswith("cHNi"), "The PSBT should start with cHNi")
 
     def complex_tx_builder(self):
-        connection: Connection = Connection.new_in_memory()
+        persister: Persister = Persister.new_in_memory()
         wallet: Wallet = Wallet(
             descriptor,
             change_descriptor,
             Network.SIGNET,
-            connection
+            persister
         )
         esplora_client: EsploraClient = EsploraClient(url = SIGNET_ESPLORA_URL)
         full_scan_request: FullScanRequest = wallet.start_full_scan().build()
diff --git a/bdk-python/tests/test_live_wallet.py b/bdk-python/tests/test_live_wallet.py
@@ -6,7 +6,7 @@
 from bdkpython import Address
 from bdkpython import Psbt
 from bdkpython import TxBuilder
-from bdkpython import Connection
+from bdkpython import Persister
 from bdkpython import Network
 from bdkpython import Amount
 from bdkpython import FeeRate
@@ -33,12 +33,12 @@ def tearDown(self) -> None:
             os.remove("./bdk_persistence.sqlite")
 
     def test_synced_balance(self):
-        connection: Connection = Connection.new_in_memory()
+        persister: Persister = Persister.new_in_memory()
         wallet: Wallet = Wallet(
             descriptor,
             change_descriptor,
             Network.SIGNET,
-            connection
+            persister
         )
         esplora_client: EsploraClient = EsploraClient(url = SIGNET_ESPLORA_URL)
         full_scan_request: FullScanRequest = wallet.start_full_scan().build()
@@ -65,12 +65,12 @@ def test_synced_balance(self):
 
 
     def test_broadcast_transaction(self):
-        connection: Connection = Connection.new_in_memory()
+        persister: Persister = Persister.new_in_memory()
         wallet: Wallet = Wallet(
             descriptor,
             change_descriptor,
             Network.SIGNET,
-            connection
+            persister
         )
         esplora_client: EsploraClient = EsploraClient(url = SIGNET_ESPLORA_URL)
         full_scan_request: FullScanRequest = wallet.start_full_scan().build()
@@ -108,4 +108,4 @@ def test_broadcast_transaction(self):
     
     
 if __name__ == '__main__':
-    unittest.main()
+    unittest.main()
diff --git a/bdk-python/tests/test_offline_wallet.py b/bdk-python/tests/test_offline_wallet.py
@@ -1,7 +1,7 @@
 from bdkpython import Descriptor
 from bdkpython import Wallet
 from bdkpython import KeychainKind
-from bdkpython import Connection
+from bdkpython import Persister
 from bdkpython import AddressInfo
 from bdkpython import Network
 
@@ -24,12 +24,12 @@ def tearDown(self) -> None:
             os.remove("./bdk_persistence.sqlite")
     
     def test_new_address(self):
-        connection: Connection = Connection.new_in_memory()
+        persister: Persister = Persister.new_in_memory()
         wallet: Wallet = Wallet(
             descriptor,
             change_descriptor,
             Network.TESTNET,
-            connection
+            persister
         )
         address_info: AddressInfo = wallet.reveal_next_address(KeychainKind.EXTERNAL)
     
@@ -41,12 +41,12 @@ def test_new_address(self):
         self.assertEqual("tb1qhjys9wxlfykmte7ftryptx975uqgd6kcm6a7z4", address_info.address.__str__())
     
     def test_balance(self):
-        connection: Connection = Connection.new_in_memory()
+        persister: Persister = Persister.new_in_memory()
         wallet: Wallet = Wallet(
             descriptor,
             change_descriptor,
             Network.TESTNET,
-            connection
+            persister
         )
     
         self.assertEqual(wallet.balance().total.to_sat(), 0)
diff --git a/bdk-swift/Tests/BitcoinDevKitTests/LiveElectrumClientTests.swift b/bdk-swift/Tests/BitcoinDevKitTests/LiveElectrumClientTests.swift
@@ -14,12 +14,12 @@ final class LiveElectrumClientTests: XCTestCase {
     )
 
     func testSyncedBalance() throws {
-        let connection = try Connection.newInMemory()
+        let persister = try Persister.newInMemory()
         let wallet = try Wallet(
             descriptor: descriptor,
             changeDescriptor: changeDescriptor,
             network: Network.signet,
-            connection: connection
+            persister: persister
         )
         let electrumClient: ElectrumClient = try ElectrumClient(url: SIGNET_ELECTRUM_URL)
         let fullScanRequest: FullScanRequest = try wallet.startFullScan().build()
diff --git a/bdk-swift/Tests/BitcoinDevKitTests/LiveKyotoTests.swift b/bdk-swift/Tests/BitcoinDevKitTests/LiveKyotoTests.swift
@@ -21,12 +21,12 @@ final class LiveKyotoTests: XCTestCase {
     }
 
     func testSuccessfullySyncs() async throws {
-        let connection = try Connection.newInMemory()
+        let persister = try Persister.newInMemory()
         let wallet = try Wallet(
             descriptor: descriptor,
             changeDescriptor: changeDescriptor,
             network: Network.signet,
-            connection: connection
+            persiter: persister
         )
         let trustedPeer = Peer(address: peer, port: nil, v2Transport: false)
         let lightClient = try CbfBuilder()
diff --git a/bdk-swift/Tests/BitcoinDevKitTests/LiveMemoryWalletTests.swift b/bdk-swift/Tests/BitcoinDevKitTests/LiveMemoryWalletTests.swift
@@ -15,12 +15,12 @@ final class LiveMemoryWalletTests: XCTestCase {
     )
 
     func testSyncedBalance() throws {
-        let connection = try Connection.newInMemory()
+        let persister = try Persister.newInMemory()
         let wallet = try Wallet(
             descriptor: descriptor,
             changeDescriptor: changeDescriptor,
             network: .signet,
-            connection: connection
+            persister: persister
         )
         let esploraClient = EsploraClient(url: SIGNET_ESPLORA_URL)
         let fullScanRequest: FullScanRequest = try wallet.startFullScan().build()
@@ -49,12 +49,12 @@ final class LiveMemoryWalletTests: XCTestCase {
     }
 
     func testScriptInspector() throws {
-        let connection = try Connection.newInMemory()
+        let persister = try Persister.newInMemory()
         let wallet = try Wallet(
             descriptor: descriptor,
             changeDescriptor: changeDescriptor,
             network: .signet,
-            connection: connection
+            persister: persister
         )
         let esploraClient = EsploraClient(url: SIGNET_ESPLORA_URL)
         let scriptInspector = FullScriptInspector()
diff --git a/bdk-swift/Tests/BitcoinDevKitTests/LiveTransactionTests.swift b/bdk-swift/Tests/BitcoinDevKitTests/LiveTransactionTests.swift
@@ -16,12 +16,12 @@ final class LiveTransactionTests: XCTestCase {
     )
 
     func testSyncedBalance() throws {
-        let connection = try Connection.newInMemory()
+        let persister = try Persister.newInMemory()
         let wallet = try Wallet(
             descriptor: descriptor,
             changeDescriptor: changeDescriptor,
             network: .signet,
-            connection: connection
+            persister: persister
         )
         let esploraClient = EsploraClient(url: SIGNET_ESPLORA_URL)
         let fullScanRequest: FullScanRequest = try wallet.startFullScan().build()
diff --git a/bdk-swift/Tests/BitcoinDevKitTests/LiveTxBuilderTests.swift b/bdk-swift/Tests/BitcoinDevKitTests/LiveTxBuilderTests.swift
diff --git a/bdk-swift/Tests/BitcoinDevKitTests/LiveWalletTests.swift b/bdk-swift/Tests/BitcoinDevKitTests/LiveWalletTests.swift
diff --git a/bdk-swift/Tests/BitcoinDevKitTests/OfflinePersistenceTests.swift b/bdk-swift/Tests/BitcoinDevKitTests/OfflinePersistenceTests.swift
diff --git a/bdk-swift/Tests/BitcoinDevKitTests/OfflineWalletTests.swift b/bdk-swift/Tests/BitcoinDevKitTests/OfflineWalletTests.swift
