ci, coldcard: clone once

Avoids spurious CI failures by not re-cloning the large repo with many submodules in every test job.

Author: Sjors

.github/actions/build-sim/action.yml

@@ -36,7 +36,17 @@ runs:
         cd test
         ./setup_environment.sh --"${{ inputs.name }}"
         cd ..
-        tar -czf "${{ inputs.archive }}.tar.gz" ${{ inputs.paths }}
+
+        # For coldcard, include the full firmware directory but strip .git directories
+        # This avoids re-cloning the large repo with many submodules in every test job
+        if [ "${{ inputs.name }}" = "coldcard" ]; then
+          # Remove .git directories to shrink the archive
+          find test/work/firmware -name ".git" -type d -exec rm -rf {} + 2>/dev/null || true
+          # Archive the full firmware directory
+          tar -czf "${{ inputs.archive }}.tar.gz" test/work/firmware
+        else
+          tar -czf "${{ inputs.archive }}.tar.gz" ${{ inputs.paths }}
+        fi
 
     - uses: actions/upload-artifact@v4
       with:

.github/actions/install-sim/action.yml

@@ -20,18 +20,13 @@ runs:
 
     - if: inputs.device == 'coldcard'
       shell: bash
-      env:
-        # Keep in sync with test/setup_environment.sh
-        COLDCARD_VERSION: "2025-09-30T1238-v5.4.4"
       run: |
         apt-get update
         apt-get install -y libpcsclite-dev libusb-1.0-0 swig
-        git config --global user.email "ci@ci.com"
-        git config --global user.name "ci"
-        # Note: cannot use --shallow-submodules because lwip submodule on git.savannah.gnu.org doesn't support it
-        pushd test/work; git clone --recursive --depth 1 --branch ${COLDCARD_VERSION} https://github.com/Coldcard/firmware.git; popd
+
+        # Extract the archive - this includes the full firmware directory
         tar -xvf coldcard-mpy.tar.gz
-        pushd test/work/firmware; git am ../../data/coldcard-multisig.patch; popd
+
         poetry run pip install -r test/work/firmware/requirements.txt
         pip install -r test/work/firmware/requirements.txt
         poetry run pip install pysdl2-dll