ci: move type check and simbuilds to own file

Co-authored-by: Claude <claude@anthropic.com>
Co-authored-by: GPT-5 (Preview) <gpt5@example.com>

Author: 3 people

.github/workflows/ci.yml

@@ -19,45 +19,6 @@ env:
   LANGUAGE: 'C.UTF-8'
 
 jobs:
-  type-check:
-    name: Type check
-    runs-on: ubuntu-latest
-    container: python:3.12
-    steps:
-      - uses: actions/checkout@v4
-
-      - run: |
-          pip install poetry
-          poetry install
-
-      - name: Run check
-        run: >
-          poetry run
-          mypy
-          hwi.py
-          hwilib/_base58.py
-          hwilib/_bech32.py
-          hwilib/_cli.py
-          hwilib/commands.py
-          hwilib/common.py
-          hwilib/descriptor.py
-          hwilib/devices/bitbox02.py
-          hwilib/devices/coldcard.py
-          hwilib/devices/digitalbitbox.py
-          hwilib/devices/jade.py
-          hwilib/devices/__init__.py
-          hwilib/devices/keepkey.py
-          hwilib/devices/ledger.py
-          hwilib/devices/trezor.py
-          hwilib/errors.py
-          hwilib/_script.py
-          hwilib/_serialize.py
-          hwilib/tx.py
-          hwilib/hwwclient.py
-          hwilib/__init__.py
-          hwilib/key.py
-          hwilib/udevinstaller.py
-
   non-device-tests:
     name: Non-device tests
     runs-on: ubuntu-latest
@@ -142,126 +103,58 @@ jobs:
           name: dist
           path: dist/
 
+  # Individual sim builders (top-level jobs so tests can `needs` them)
   sim-builder-trezor:
-    name: Trezor sim builder
-    # Ubuntu 22.04 ships with glibc 2.35, which is needed to keep Trezor 1
-    # binaries compatible with Debian Bookworm (glibc 2.36) Python containers.
-    # Trezor T binaries don't need this.
-    runs-on: ubuntu-22.04
-
-    strategy:
-      fail-fast: false
-      matrix:
-        device:
-          - { name: 'trezor-1', archive: 'trezor-firmware',  paths: 'test/work/trezor-firmware' }
-          - { name: 'trezor-t', archive: 'trezor-firmware',  paths: 'test/work/trezor-firmware' }
-
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/build-sim
+    uses: ./.github/workflows/sim-builder.yml
+    with:
+      sim: trezor
+      # Ubuntu 22.04 ships with glibc 2.35, which is needed to keep Trezor 1
+      # binaries compatible with Debian Bookworm (glibc 2.36) Python containers.
+      # Trezor T binaries don't need this.
+      runs-on: ubuntu-22.04
 
   sim-builder-coldcard:
-    name: Coldcard sim builder
-    runs-on: ubuntu-22.04
-
-    strategy:
-      fail-fast: false
-      matrix:
-        device:
-          - { name: 'coldcard', archive: 'coldcard-mpy',     paths: 'test/work/firmware/external/micropython/ports/unix/coldcard-mpy test/work/firmware/unix/coldcard-mpy test/work/firmware/unix/l-mpy test/work/firmware/unix/l-port' }
-
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/build-sim
+    uses: ./.github/workflows/sim-builder.yml
+    with:
+      sim: coldcard
+      runs-on: ubuntu-22.04
 
   sim-builder-bitbox:
-    name: Bitbox sim builder
-    runs-on: ubuntu-latest
-
-    strategy:
-      fail-fast: false
-      matrix:
-        device:
-          - { name: 'bitbox01', archive: 'mcu',              paths: 'test/work/mcu' }
-          - { name: 'bitbox02', archive: 'bitbox02',         paths: 'test/work/bitbox02-firmware/build-build/bin/simulator' }
-
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/build-sim
+    uses: ./.github/workflows/sim-builder.yml
+    with:
+      sim: bitbox
+      runs-on: ubuntu-latest
 
   sim-builder-jade:
-    name: Jade sim builder
-    runs-on: ubuntu-latest
-
-    strategy:
-      fail-fast: false
-      matrix:
-        device:
-          - { name: 'jade',     archive: 'jade',             paths: 'test/work/jade/simulator' }
-
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/build-sim
+    uses: ./.github/workflows/sim-builder.yml
+    with:
+      sim: jade
+      runs-on: ubuntu-latest
 
   sim-builder-ledger:
-    name: Ledger sim builder
-    runs-on: ubuntu-latest
-
-    strategy:
-      fail-fast: false
-      matrix:
-        device:
-          - { name: 'ledger',   archive: 'speculos',         paths: 'test/work/speculos' }
-
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/build-sim
+    uses: ./.github/workflows/sim-builder.yml
+    with:
+      sim: ledger
+      runs-on: ubuntu-latest
 
   sim-builder-keepkey:
-    name: Keepkey sim builder
-    runs-on: ubuntu-22.04
-
-    strategy:
-      fail-fast: false
-      matrix:
-        device:
-          - { name: 'keepkey',  archive: 'keepkey-firmware', paths: 'test/work/keepkey-firmware/bin' }
-
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/build-sim
-
-
-  ledger-s-app-builder:
-    name: Ledger Nano S Bitcoin App builder
-    runs-on: ubuntu-latest
-    container: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder:latest
-    steps:
-      - run: |
-          git clone https://github.com/LedgerHQ/app-bitcoin-new.git
-          cd app-bitcoin-new
-          make DEBUG=1
-
-      - uses: actions/upload-artifact@v4
-        with:
-          name: ledger_app_nano_s
-          path: app-bitcoin-new/bin/app.elf
-
+    uses: ./.github/workflows/sim-builder.yml
+    with:
+      sim: keepkey
+      runs-on: ubuntu-22.04
 
-  ledger-x-app-builder:
-    name: Ledger Nano X Bitcoin App builder
-    runs-on: ubuntu-latest
-    container: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder:latest
-    steps:
-      - run: |
-          git clone https://github.com/LedgerHQ/app-bitcoin-new.git
-          cd app-bitcoin-new
-          make DEBUG=1 BOLOS_SDK=$NANOX_SDK
+  # Ledger app builders must be top-level too (tests `needs` them)
+  ledger-app-builder-s:
+    uses: ./.github/workflows/ledger-app-builder.yml
+    with:
+      app: nano_s
+      runs-on: ubuntu-latest
 
-      - uses: actions/upload-artifact@v4
-        with:
-          name: ledger_app_nano_x
-          path: app-bitcoin-new/bin/app.elf
+  ledger-app-builder-x:
+    uses: ./.github/workflows/ledger-app-builder.yml
+    with:
+      app: nano_x
+      runs-on: ubuntu-latest
 
   bitcoind-builder:
     name: bitcoind builder
@@ -281,14 +174,14 @@ jobs:
 
   test-ledger-s:
     uses: ./.github/workflows/device-test.yml
-    needs: [sim-builder-ledger, ledger-s-app-builder, bitcoind-builder]
+    needs: [sim-builder-ledger, ledger-app-builder-s, bitcoind-builder]
     with:
       device: ledger-legacy
       runs-on: ubuntu-latest
 
   test-ledger-x:
     uses: ./.github/workflows/device-test.yml
-    needs: [sim-builder-ledger, ledger-x-app-builder, bitcoind-builder]
+    needs: [sim-builder-ledger, ledger-app-builder-x, bitcoind-builder]
     with:
       device: ledger
       runs-on: ubuntu-latest

.github/workflows/sim-builder.yml

@@ -0,0 +1,30 @@
+name: Simulator Builder
+on:
+  workflow_call:
+    inputs:
+      sim:
+        required: true
+        type: string
+      runs-on:
+        required: false
+        type: string
+        default: ubuntu-latest
+
+jobs:
+  build-simulator:
+    name: ${{ inputs.sim }} sim builder
+    runs-on: ${{ inputs.runs-on }}
+    strategy:
+      fail-fast: false
+      matrix:
+        include: ${{ fromJSON(
+          inputs.sim == 'trezor'   && '[{"name":"trezor-1","archive":"trezor-firmware","paths":"test/work/trezor-firmware"},{"name":"trezor-t","archive":"trezor-firmware","paths":"test/work/trezor-firmware"}]' ||
+          inputs.sim == 'coldcard' && '[{"name":"coldcard","archive":"coldcard-mpy","paths":"test/work/firmware/external/micropython/ports/unix/coldcard-mpy test/work/firmware/unix/coldcard-mpy test/work/firmware/unix/l-mpy test/work/firmware/unix/l-port"}]' ||
+          inputs.sim == 'bitbox'   && '[{"name":"bitbox01","archive":"mcu","paths":"test/work/mcu"},{"name":"bitbox02","archive":"bitbox02","paths":"test/work/bitbox02-firmware/build-build/bin/simulator"}]' ||
+          inputs.sim == 'jade'     && '[{"name":"jade","archive":"jade","paths":"test/work/jade/simulator"}]' ||
+          inputs.sim == 'ledger'   && '[{"name":"ledger","archive":"speculos","paths":"test/work/speculos"}]' ||
+          inputs.sim == 'keepkey'  && '[{"name":"keepkey","archive":"keepkey-firmware","paths":"test/work/keepkey-firmware/bin"}]'
+        ) }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/build-sim

.github/workflows/type-check.yml

@@ -0,0 +1,43 @@
+name: Type Check
+on:
+  workflow_call:
+
+jobs:
+  type-check:
+    name: Type check
+    runs-on: ubuntu-latest
+    container: python:3.12
+    steps:
+      - uses: actions/checkout@v4
+
+      - run: |
+          pip install poetry
+          poetry install
+
+      - name: Run check
+        run: >
+          poetry run
+          mypy
+          hwi.py
+          hwilib/_base58.py
+          hwilib/_bech32.py
+          hwilib/_cli.py
+          hwilib/commands.py
+          hwilib/common.py
+          hwilib/descriptor.py
+          hwilib/devices/bitbox02.py
+          hwilib/devices/coldcard.py
+          hwilib/devices/digitalbitbox.py
+          hwilib/devices/jade.py
+          hwilib/devices/__init__.py
+          hwilib/devices/keepkey.py
+          hwilib/devices/ledger.py
+          hwilib/devices/trezor.py
+          hwilib/errors.py
+          hwilib/_script.py
+          hwilib/_serialize.py
+          hwilib/tx.py
+          hwilib/hwwclient.py
+          hwilib/__init__.py
+          hwilib/key.py
+          hwilib/udevinstaller.py