-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathjikan_api_test.go
More file actions
476 lines (412 loc) · 13.3 KB
/
jikan_api_test.go
File metadata and controls
476 lines (412 loc) · 13.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
package main
import (
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
"time"
"github.com/stretchr/testify/assert"
)
// newTestJikanClient creates a JikanClient pointing at a test server.
func newTestJikanClient(t *testing.T, serverURL, cacheDir string) *JikanClient {
t.Helper()
cache := NewJikanCache(cacheDir, 168*time.Hour)
return &JikanClient{
baseURL: serverURL,
httpClient: &http.Client{Timeout: 5 * time.Second},
cache: cache,
}
}
func jikanMangaResponse(id int, title, titleEN, titleJP string) map[string]any {
return map[string]any{
"data": map[string]any{
"mal_id": id,
"title": title,
"title_english": titleEN,
"title_japanese": titleJP,
"title_synonyms": []string{},
"type": "Manga",
"chapters": nil,
"volumes": nil,
"status": "Publishing",
},
}
}
func jikanSearchResponseHelper(entries ...map[string]any) map[string]any {
data := make([]any, 0, len(entries))
for _, e := range entries {
data = append(data, e)
}
return map[string]any{
"data": data,
"pagination": map[string]any{
"last_visible_page": 1,
"has_next_page": false,
},
}
}
func jikanSearchEntry(id int, title, titleEN, titleJP string) map[string]any {
return map[string]any{
"mal_id": id,
"title": title,
"title_english": titleEN,
"title_japanese": titleJP,
"title_synonyms": []string{},
"type": "Manga",
"chapters": nil,
"volumes": nil,
"status": "Publishing",
}
}
func TestJikanClient_GetMangaByMALID(t *testing.T) {
t.Parallel()
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.URL.Path == "/manga/13" {
writeJSON(t, w, jikanMangaResponse(13, "One Piece", "One Piece", "ONE PIECE"))
return
}
w.WriteHeader(http.StatusNotFound)
}))
defer server.Close()
tmpDir := t.TempDir()
client := newTestJikanClient(t, server.URL, tmpDir)
ctx := NewLogger(false).WithContext(t.Context())
data, found := client.GetMangaByMALID(ctx, 13)
assert.True(t, found)
assert.NotNil(t, data)
assert.Equal(t, 13, data.MalID)
assert.Equal(t, "One Piece", data.Title)
assert.Equal(t, "One Piece", data.TitleEnglish)
assert.Equal(t, "ONE PIECE", data.TitleJapanese)
}
func TestJikanClient_GetMangaByMALID_CacheHit(t *testing.T) {
t.Parallel()
requestCount := 0
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
requestCount++
writeJSON(t, w, jikanMangaResponse(13, "One Piece", "One Piece", "ONE PIECE"))
}))
defer server.Close()
tmpDir := t.TempDir()
client := newTestJikanClient(t, server.URL, tmpDir)
ctx := NewLogger(false).WithContext(t.Context())
// First request — API call
data1, found1 := client.GetMangaByMALID(ctx, 13)
assert.True(t, found1)
assert.Equal(t, 13, data1.MalID)
assert.Equal(t, 1, requestCount)
// Second request — cache hit
data2, found2 := client.GetMangaByMALID(ctx, 13)
assert.True(t, found2)
assert.Equal(t, 13, data2.MalID)
assert.Equal(t, 1, requestCount, "Second request should NOT hit API (cache hit)")
}
func TestJikanClient_GetMangaByMALID_NotFound(t *testing.T) {
t.Parallel()
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusNotFound)
}))
defer server.Close()
tmpDir := t.TempDir()
client := newTestJikanClient(t, server.URL, tmpDir)
ctx := NewLogger(false).WithContext(t.Context())
data, found := client.GetMangaByMALID(ctx, 999999)
assert.False(t, found)
assert.Nil(t, data)
}
func TestJikanClient_GetMangaByMALID_NegativeCache(t *testing.T) {
t.Parallel()
requestCount := 0
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
requestCount++
w.WriteHeader(http.StatusNotFound)
}))
defer server.Close()
tmpDir := t.TempDir()
client := newTestJikanClient(t, server.URL, tmpDir)
ctx := NewLogger(false).WithContext(t.Context())
// First request — 404
_, found1 := client.GetMangaByMALID(ctx, 999999)
assert.False(t, found1)
assert.Equal(t, 1, requestCount)
// Second request — should hit negative cache
_, found2 := client.GetMangaByMALID(ctx, 999999)
assert.False(t, found2)
assert.Equal(t, 1, requestCount, "Should hit negative cache")
}
func TestJikanClient_SearchManga(t *testing.T) {
t.Parallel()
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
query := r.URL.Query().Get("q")
if query == "One Piece" {
writeJSON(t, w, jikanSearchResponseHelper(
jikanSearchEntry(13, "One Piece", "One Piece", "ONE PIECE"),
jikanSearchEntry(100, "One Piece: Film Z", "One Piece Film Z", ""),
))
return
}
writeJSON(t, w, jikanSearchResponseHelper())
}))
defer server.Close()
tmpDir := t.TempDir()
client := newTestJikanClient(t, server.URL, tmpDir)
ctx := NewLogger(false).WithContext(t.Context())
results := client.SearchManga(ctx, "One Piece")
assert.Len(t, results, 2)
assert.Equal(t, 13, results[0].MalID)
assert.Equal(t, "One Piece", results[0].Title)
}
func TestJikanClient_SearchManga_Empty(t *testing.T) {
t.Parallel()
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
writeJSON(t, w, jikanSearchResponseHelper())
}))
defer server.Close()
tmpDir := t.TempDir()
client := newTestJikanClient(t, server.URL, tmpDir)
ctx := NewLogger(false).WithContext(t.Context())
results := client.SearchManga(ctx, "nonexistent_manga_xyz")
assert.Empty(t, results)
}
func TestJikanAPIStrategy_FindTarget_MangaFound(t *testing.T) {
t.Parallel()
// Seed cache directly to avoid HTTP calls
tmpDir := t.TempDir()
cache := NewJikanCache(tmpDir, 168*time.Hour)
searchResults := []JikanMangaData{
{MalID: 92182, Title: "Seishun Buta Yarou", TitleEnglish: "Rascal Does Not Dream of Bunny Girl Senpai", TitleJapanese: "青春ブタ野郎"},
}
encoded, _ := json.Marshal(searchResults)
cache.SetSearch("Seishun Buta Yarou", encoded)
client := &JikanClient{cache: cache}
strategy := JikanAPIStrategy{Client: client}
ctx := NewLogger(false).WithContext(t.Context())
// AniList→MAL direction: IDMal=0, need to find it
src := Manga{
IDAnilist: 87471,
IDMal: 0,
TitleEN: "Rascal Does Not Dream of Bunny Girl Senpai",
TitleJP: "青春ブタ野郎",
TitleRomaji: "Seishun Buta Yarou",
}
targetManga := Manga{
IDAnilist: 87471,
IDMal: 92182,
TitleEN: "Rascal Does Not Dream of Bunny Girl Senpai",
TitleJP: "青春ブタ野郎",
TitleRomaji: "Seishun Buta Yarou",
}
existingTargets := map[TargetID]Target{
TargetID(92182): targetManga,
}
target, found, err := strategy.FindTarget(ctx, src, existingTargets, "test", nil)
assert.NoError(t, err)
assert.True(t, found)
assert.Equal(t, "Rascal Does Not Dream of Bunny Girl Senpai", target.GetTitle())
}
func TestJikanAPIStrategy_FindTarget_SkipsAnime(t *testing.T) {
t.Parallel()
tmpDir := t.TempDir()
cache := NewJikanCache(tmpDir, 168*time.Hour)
client := &JikanClient{cache: cache}
strategy := JikanAPIStrategy{Client: client}
ctx := NewLogger(false).WithContext(t.Context())
src := Anime{
IDMal: 1,
IDAnilist: 0,
TitleEN: "Cowboy Bebop",
}
existingTargets := map[TargetID]Target{}
target, found, err := strategy.FindTarget(ctx, src, existingTargets, "test", nil)
assert.NoError(t, err)
assert.False(t, found)
assert.Nil(t, target)
}
func TestJikanAPIStrategy_NilClient(t *testing.T) {
t.Parallel()
strategy := JikanAPIStrategy{Client: nil}
ctx := NewLogger(false).WithContext(t.Context())
src := Manga{IDMal: 0, IDAnilist: 123}
existingTargets := map[TargetID]Target{}
target, found, err := strategy.FindTarget(ctx, src, existingTargets, "test", nil)
assert.NoError(t, err)
assert.False(t, found)
assert.Nil(t, target)
}
func TestJikanAPIStrategy_FindTarget_ReverseDirection(t *testing.T) {
t.Parallel()
// Seed cache with manga data for MAL ID lookup
tmpDir := t.TempDir()
cache := NewJikanCache(tmpDir, 168*time.Hour)
mangaData := JikanMangaData{
MalID: 92182,
Title: "Seishun Buta Yarou",
TitleEnglish: "Rascal Does Not Dream of Bunny Girl Senpai",
TitleJapanese: "青春ブタ野郎",
}
encoded, _ := json.Marshal(mangaData)
cache.Set(92182, encoded)
client := &JikanClient{cache: cache}
strategy := JikanAPIStrategy{Client: client}
ctx := NewLogger(false).WithContext(t.Context())
// MAL→AniList direction: IDAnilist=0, need to find match by title
src := Manga{
IDAnilist: 0,
IDMal: 92182,
TitleEN: "Rascal Does Not Dream of Bunny Girl Senpai",
TitleJP: "青春ブタ野郎",
TitleRomaji: "",
}
targetManga := Manga{
IDAnilist: 87471,
IDMal: 92182,
TitleEN: "Rascal Does Not Dream of Bunny Girl Senpai",
TitleJP: "青春ブタ野郎",
TitleRomaji: "Seishun Buta Yarou",
}
existingTargets := map[TargetID]Target{
TargetID(87471): targetManga,
}
target, found, err := strategy.FindTarget(ctx, src, existingTargets, "test", nil)
assert.NoError(t, err)
assert.True(t, found)
assert.Equal(t, "Rascal Does Not Dream of Bunny Girl Senpai", target.GetTitle())
}
func TestMatchJikanMangaToSource(t *testing.T) {
t.Parallel()
tests := []struct {
name string
jikan JikanMangaData
en, jp string
romaji string
expected bool
}{
{
name: "exact english match",
jikan: JikanMangaData{TitleEnglish: "One Piece", TitleJapanese: "ONE PIECE", Title: "One Piece"},
en: "One Piece",
jp: "",
romaji: "",
expected: true,
},
{
name: "exact japanese match",
jikan: JikanMangaData{TitleEnglish: "", TitleJapanese: "ONE PIECE", Title: "One Piece"},
en: "",
jp: "ONE PIECE",
romaji: "",
expected: true,
},
{
name: "romaji to title match",
jikan: JikanMangaData{TitleEnglish: "", TitleJapanese: "", Title: "Seishun Buta Yarou"},
en: "",
jp: "",
romaji: "Seishun Buta Yarou",
expected: true,
},
{
name: "no match",
jikan: JikanMangaData{TitleEnglish: "Naruto", TitleJapanese: "ナルト", Title: "Naruto"},
en: "One Piece",
jp: "ONE PIECE",
romaji: "One Piece",
expected: false,
},
{
name: "synonym match",
jikan: JikanMangaData{
TitleEnglish: "Bunny Girl Senpai",
TitleJapanese: "青春ブタ野郎",
Title: "Seishun Buta Yarou",
TitleSynonyms: []string{"Rascal Does Not Dream of Bunny Girl Senpai"},
},
en: "Rascal Does Not Dream of Bunny Girl Senpai",
jp: "",
romaji: "",
expected: true,
},
{
name: "cross match EN vs romaji",
jikan: JikanMangaData{TitleEnglish: "", TitleJapanese: "", Title: "Seishun Buta Yarou"},
en: "Seishun Buta Yarou",
jp: "",
romaji: "",
expected: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := matchJikanMangaToSource(t.Context(), &tt.jikan, tt.en, tt.jp, tt.romaji)
assert.Equal(t, tt.expected, result)
})
}
}
func TestFindBestJikanMatch(t *testing.T) {
t.Parallel()
results := []JikanMangaData{
{MalID: 100, Title: "One Piece Film Z", TitleEnglish: "One Piece Film Z", TitleJapanese: ""},
{MalID: 13, Title: "One Piece", TitleEnglish: "One Piece", TitleJapanese: "ONE PIECE"},
}
malID := findBestJikanMatch(t.Context(), results, "One Piece", "ONE PIECE", "")
assert.Equal(t, 13, malID)
}
func TestFindBestJikanMatch_NoMatch(t *testing.T) {
t.Parallel()
results := []JikanMangaData{
{MalID: 100, Title: "Naruto", TitleEnglish: "Naruto", TitleJapanese: "ナルト"},
}
malID := findBestJikanMatch(t.Context(), results, "One Piece", "ONE PIECE", "")
assert.Equal(t, 0, malID)
}
func TestSearchTitlesForJikan(t *testing.T) {
t.Parallel()
titles := searchTitlesForJikan("One Piece", "", "One Piece")
// Should deduplicate "One Piece" (romaji == EN after normalization)
assert.Len(t, titles, 1)
titles2 := searchTitlesForJikan("Rascal Does Not Dream", "", "Seishun Buta Yarou")
assert.Len(t, titles2, 2)
assert.Equal(t, "Seishun Buta Yarou", titles2[0]) // romaji first
assert.Equal(t, "Rascal Does Not Dream", titles2[1]) // then EN
}
func TestSearchTitlesForJikan_Empty(t *testing.T) {
t.Parallel()
titles := searchTitlesForJikan("", "", "")
assert.Empty(t, titles)
}
func TestJikanClient_GetMangaByMALID_InvalidID(t *testing.T) {
t.Parallel()
tmpDir := t.TempDir()
cache := NewJikanCache(tmpDir, 168*time.Hour)
client := &JikanClient{cache: cache}
ctx := NewLogger(false).WithContext(t.Context())
data, found := client.GetMangaByMALID(ctx, 0)
assert.False(t, found)
assert.Nil(t, data)
data, found = client.GetMangaByMALID(ctx, -1)
assert.False(t, found)
assert.Nil(t, data)
}
func TestJikanClient_SearchManga_EmptyQuery(t *testing.T) {
t.Parallel()
tmpDir := t.TempDir()
cache := NewJikanCache(tmpDir, 168*time.Hour)
client := &JikanClient{cache: cache}
ctx := NewLogger(false).WithContext(t.Context())
results := client.SearchManga(ctx, "")
assert.Nil(t, results)
}
func TestJikanClient_ServerError(t *testing.T) {
t.Parallel()
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusInternalServerError)
}))
defer server.Close()
tmpDir := t.TempDir()
client := newTestJikanClient(t, server.URL, tmpDir)
ctx := NewLogger(false).WithContext(t.Context())
// Server error is non-fatal
data, found := client.GetMangaByMALID(ctx, 1)
assert.False(t, found)
assert.Nil(t, data)
}