From 6b45154c877cddaac781baf0ea73431cd53813f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=B1=AA=E7=BB=86=E5=8B=96=28WangXixu=29-=E9=A1=BA?= =?UTF-8?q?=E4=B8=B0=E7=A7=91=E6=8A=80=E6=8A=80=E6=9C=AF=E9=9B=86=E5=9B=A2?= Date: Tue, 28 Oct 2025 09:49:00 +0800 Subject: [PATCH] fix memory leak --- velox/connectors/print/PrintSink.cpp | 4 +--- velox/connectors/print/PrintSink.h | 2 ++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/velox/connectors/print/PrintSink.cpp b/velox/connectors/print/PrintSink.cpp index feb9abc3219e..e74a3007d52b 100644 --- a/velox/connectors/print/PrintSink.cpp +++ b/velox/connectors/print/PrintSink.cpp @@ -40,8 +40,6 @@ std::unique_ptr PrintSink::createWriter( if (fs->exists(path)) { fs->remove(path); } - std::shared_ptr ioStats = - std::make_shared(); std::unique_ptr writeFileSink = dwio::common::FileSink::create( path, @@ -49,7 +47,7 @@ std::unique_ptr PrintSink::createWriter( .bufferWrite = false, .pool = queryCtx_->memoryPool(), .metricLogger = dwio::common::MetricsLog::voidLog(), - .stats = ioStats.get(), + .stats = &ioStats_, }); auto writerFactory = dwio::common::getWriterFactory(dwio::common::FileFormat::TEXT); diff --git a/velox/connectors/print/PrintSink.h b/velox/connectors/print/PrintSink.h index cf6e00f29919..1e0caac51c4a 100644 --- a/velox/connectors/print/PrintSink.h +++ b/velox/connectors/print/PrintSink.h @@ -42,6 +42,8 @@ class PrintSink : public DataSink { connector::DataSink::Stats stats() const override; + io::IoStatistics ioStats_; + private: const RowTypePtr inputType_; const RowTypePtr outputType_;