going back in history doesn't erase entire line

[fredo514]

When using the history option, when going back in the command history with the up arrow key, if the previous command is shorter than the current line content, the rest of the current line is still displayed after the new command text.

It would be nice if it erased the entire line each time when going back in history.

I'll try to find some time to submit a PR.

[bgomberg]

I haven't been able to reproduce this. Could you give me some steps to follow and let me know what terminal program / options you're using as well as your console_config.h.

[fredo514]

Really, I've only powered up, typed a few commands and tried to go back in history. I'm using TeraTerm so maybe it doesn't handle some command characters right. I'll try with another terminal to see.

In the meantime, here's the config I'm using:

#pragma once

// See the README for documentation on these options.

#ifndef CONSOLE_MAX_COMMANDS
#    define CONSOLE_MAX_COMMANDS 16
#endif

#ifndef CONSOLE_MAX_LINE_LENGTH
#    define CONSOLE_MAX_LINE_LENGTH 128
#endif

#ifndef CONSOLE_PROMPT
#    define CONSOLE_PROMPT "> "
#endif

#ifndef CONSOLE_RETURN_KEY
#    define CONSOLE_RETURN_KEY '\n'
#endif

#ifndef CONSOLE_NEWLINE
#    define CONSOLE_NEWLINE "\r\n"
#endif

#ifndef CONSOLE_BUFFER_ATTRIBUTES
#    define CONSOLE_BUFFER_ATTRIBUTES
#endif

#ifndef CONSOLE_HELP_COMMAND
#    define CONSOLE_HELP_COMMAND 1
#endif

#ifndef CONSOLE_FULL_CONTROL
#    define CONSOLE_FULL_CONTROL 1
#endif

#ifndef CONSOLE_TAB_COMPLETE
#    define CONSOLE_TAB_COMPLETE 1
#endif

#if CONSOLE_TAB_COMPLETE && !CONSOLE_FULL_CONTROL
#    error "CONSOLE_TAB_COMPLETE requires CONSOLE_FULL_CONTROL to be enabled"
#endif

#ifndef CONSOLE_HISTORY
#    define CONSOLE_HISTORY 5
#endif

#if CONSOLE_HISTORY && !CONSOLE_FULL_CONTROL
#    error "CONSOLE_HISTORY requires CONSOLE_FULL_CONTROL to be enabled"
#endif