Skip to content

run_system_cached API will reject systems created by pipe and map #15373

@benfrankel

Description

@benfrankel

From #14920 (review):

The only maybe issue I can see is that the ZST check won't work for systems created by pipe and map, even when the systems and closures involved are ZSTs. This is due to pipe and map eagerly calling into_system on their receiver, which will result in non-ZST types even when called on ZST types. The solution would be changing them to be lazy and call into_system on their receiver only when into_system is directly called on them.

- @SkiFire13

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ECSEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorD-ModestA "normal" level of difficulty; suitable for simple features or challenging fixesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions