The presence of `*__in` should overwrite any default values of `number`

[slaFFik]

When using edd_get_customers() function (just
an example, applies to any layers using Berlin db, I suppose) with id__in key in its arguments, the default EDD number=30 value should be ignored and should default to the count( $id_in ) value.

If I provide a list of explicit ids, I expect the function/DB query to return those explicit values (minus those that to not exist in DB, but that will be handled by database natively) I requested - not cutting the values off because of the internal default value.

Same applies to any variations of *__in and *__not_in.

[JJJ]

Off the top of my head, I think this might not be right.

number translates to LIMIT %d with a possible offset, which could still be relevant if number was 10 and the __in query var contained 100 items.

Maybe? 😬

[slaFFik]

I see your point, but I'm talking about situations when number hasn't been provided at all.

After creating this task I noticed that EDD won't benefit from it (without additional changes) because they always put the hard limit of 30 regardless of id__in or not if number hasn't been passed.
Example:

function edd_get_customers( $args = array() ) {

	// Parse args
	$r = wp_parse_args( $args, array(
		'number' => 30
	) );

....

If the user provided number - it should always be respected, no questions.

If there is no number - the LIMIT should either NOT be added to the request, or it should be count( $__in ) or whatever __in/__not_in has been passed.

Right now, Query.php has a number limited to 100 (https://github.com/berlindb/core/blob/master/src/Database/Query.php#L456C4-L456C31) and passing "ins"/"not ins" does not change that limit.
Also, in other place I see limit defaults to 25 for some reason. Might be worth just setting a constant in the class which can be redefined inside parent classes that extend Query.php - so the value is consistent.

[JJJ]

Does it work the way you want if you explicitly set number to 0 in your query args?

Might be worth just setting a constant in the class which can be redefined inside parent classes that extend Query.php - so the value is consistent.

Yeah totally agree with you there 💯

The query vars default to 100 to prevent unintended unbound queries.

It's only the public get_results() method that sets an even more conservative 25, in an attempt to match what applications (like EDD) would normally expect. This method isn't actually used by Berlin, it's just a "convenient" argument-based wrapper for the most common query() array args.

If there is no number - the LIMIT should either NOT be added to the request, or it should be count( $__in ) or whatever __in/__not_in has been passed.

If we didn't add a limit, it would be an unbound query for all results by default, which isn't ideal either. 🧐