-
Notifications
You must be signed in to change notification settings - Fork 50
Open
Description
I've been trying to use the module with react-admin-firebase, however react-admin-firbease does return objects for the getMany calls (with just ids) even if those do not exist, which forced me to use the getOne instead.
However, It seems that when resource is successfully obtained via getOne the id is marked as non colliding, and when there is an error when querying the resource it is marked as colliding, which is the exact opposite of how it should work.
react-admin-import-csv/src/import-controller.ts
Lines 65 to 67 in d85b212
| return dataProvider.getOne(resourceName, {id}) | |
| .then(_ => undefined) | |
| .catch(_ => id); |
Simply replacing the return value of then with return value of catch and vice verse should fix the issue.
Metadata
Metadata
Assignees
Labels
No labels