Generated javascript is missing imports required for Type.resolveClass to work

[theJenix]

I am running into an issue where I have a class in Haxe that looks like:

// Request.hx
import pkg.DataType;

class Request {
}

class Response {
  final data: DataType
}

When I run this through genes, it emits Request.d.ts that contains an import for pkg.DataType, and Request.js, which does not have the import. The problem here is that the import is needed for $hxClasses to be populated with the DataType type, and that is required for Type.resolveClass to work.

[theJenix]

From what I can see, the pkg.DataType shows up in the modules typeDependencies but not in the codeDependencies. I did a quick experiment where I tried emitting the set of both dependencies in the .js file, and that broke all sorts of things. But I think the two solutions to this are either something long these lines, or move the Register calls that are in each .js file to some central file. Happy to submit a PR on this, if you can give me some pointers on which would be the better solution (or any other solutions you have in mind here)!

[benmerckx]

I think doing this correctly would mean we need a central list of all classes as you suggested. It could be generated only if (api: JSGenApi).hasFeature('Type.resolveClass'). I see that the resolveClass (and resolveEnum) method is inlined. So we'd need to include either an import to $hxClasses into the files where it is used, or define it globally.

My suggestion would be to gather all the info at the end of genes.Generator.generate and then generate a file at output/$hxClasses.js which exports every class by name into an export ( export const $hxClasses = { ... }). Then import this variable in the files where needed.