Regression in argument parsing

[baprx]

I noticed a regression since the golang rewrite, it was possible to call sshush with multiple source values with a single flag but it's not possible anymore.

I was using sshush --source ~/.ssh/config.yml ~/.ssh/sshush-gcp-*.yml which was very useful.

I quickly tried to make it work using viper with no lock and I'm running out of time 😁.

Is it something you expected or should it be treated as a bug?

[bencromwell]

It requires quoting, I'm not sure why. I couldn't find a solution and I ended up updating my alias to:

alias compilessh='sshush --source "~/projects/ssh-config/*.yml"'

It's certainly something to do with either Cobra or Viper. I was hoping once I got more familiar with Go I'd find an answer! I'd definitely consider it a bug.

[baprx]

Thank you for the workaround!

From what I understand it's a matter of who is handling the glob expression:

If it's the shell we end up with a command similar to sshush --source ~/projects/ssh-config/a.yml ~/projects/ssh-config/b.yml
With the quotes cobra only receives ~/projects/ssh-config/*.yml and the glob expression is expanded here.

The python version was configured so it would append multiple arguments in a list instead of considering the input as one value (["~/projects/ssh-config/a.yml", "~/projects/ssh-config/b.yml"] instead of ["~/projects/ssh-config/a.yml ~/projects/ssh-config/b.yml"]).