omp dump pass fails on lulesh with LLVM 3.9

[pablooliveira]

/home/poliveira/clang+llvm-3.9.1-aarch64-linux-gnu/bin/opt -S -load /home/poliveira/local/lib/libcere_regiondump.so -omp-region-dump  --region=__cere__lulesh__ZL28CalcHourglassControlForElemsR6DomainPdd_1037 --invocation=1  lulesh.ll -o lulesh.ll

Basic Block in function '__cere__lulesh__ZL28CalcHourglassControlForElemsR6DomainPdd_1037' does not have terminator!
label %newFuncRoot
LLVM ERROR: Broken function found, compilation aborted!

@mihailpopov do you have an idea of what is going on ? I know in aarch64 some changes were commited to the way openmp microtasks were outlined in LLVM 3.9. Maybe it could be that ?

[pablooliveira]

I just tested it in LLVM 3.8 on the same CERE version and platform and it works well. So this in LLVM 3.9 triggered.

[mihailpopov]

It is not the outlining pass that fails: it is the dump compilation pass.

I was able to replay this region (with a dump generated with LLVM 3.8) => the outlining pass was successfully used by the replay pass of LLVM 3.9.

Moreover, I tested the following commands:
clang -g -O3 -fopenmp -Wall -O0 -g -DUSE_OMP=1 -DUSE_MPI=0 -I. lulesh.cc -S -emit-llvm -o lulesh.ll
opt -S -load /usr/local/lib/libcere_regionoutliner.so -omp-region-outliner lulesh.ll -o lulesh2.ll
opt -S -load /usr/local/lib/libcere_regiondump.so -omp-region-dump --region=__cere__lulesh__ZL28CalcHourglassControlForElemsR6DomainPdd_1037 --invocation=1 lulesh2.ll -o lulesh3.ll

I checked the .ll file validity after the outlining and it looked ok. So, the issue appears during the dump pass: I will focus there.

[pablooliveira]

This is also confirmed on x86.