-
Notifications
You must be signed in to change notification settings - Fork 14
Open
Labels
Description
For now we have code for emitting errors about non existent BEM modules.
Lines 139 to 144 in e9c1640
| Object.keys(existsEntities).forEach(fileId => { | |
| // check if entity has no tech to resolve | |
| existsEntities[fileId] || errEntities[fileId].forEach(file => { | |
| this.emitError(`BEM module not found: ${file.path}`); | |
| }); | |
| }); |
In real projects it looks like infinite noise that does not help.
At the same time emitError requires a special as an argument as passing there a string generates Critical errors inside Webpack itself.
ERROR in ./blocks/block-a/block-a.react.js
(Emitted value instead of an instance of Error) BEM module not found: ../block-b/block-b.css
@ ./blocks/block-a/block-a.examples/index.react.js 21:26-59 21:71-104
Actually, there are 2 cases that we should fix here:
- Create an error object instead of string to pass it in emitError
- Reduce count of errors (to a zero if possible)
Reactions are currently unavailable