Keep Getting An Error

[jackcooperdev]

I have matched the format of the JSON Feed in your example yet when I attempt to convert I get this error UnhandledPromiseRejectionWarning: Error: jsonfeed-to-atom: JSON feed version 1 required

[bcomnes]

A valid json feed requires a version field, but it looks like that test is overly strict and needs to be updated for version 1.1. I’ll get a patch in soon

…

Sent from my mobile

On Oct 29, 2020, at 6:37 AM, Jack Cooper ***@***.***> wrote:  I have matched the format of the JSON Feed in your example yet when I attempt to convert I get this error UnhandledPromiseRejectionWarning: Error: jsonfeed-to-atom: JSON feed version 1 required — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[bcomnes]

Digging in a little more:

jsonfeed-to-rss/jsonfeed-to-rss-object.js

Lines 41 to 44 in ebbbfb7

	if (version !== 'https://jsonfeed.org/version/1') throw new Error('jsonfeed-to-atom: JSON feed version 1 required')
	if (!title) throw new Error('jsonfeed-to-rss: missing title')
	if (!feedURL) throw new Error('jsonfeed-to-atom: missing feed_url')
	if (!homePageURL) throw new Error('jsonfeed-to-rss: JSON feed missing home_page_url property')

jsonfeed-to-rss will refuse to serialize an invalid jsonfeed, meaning if there are any missing required fields it will throw that error.

In which case, the object it received was lacking this field:

"version":"https://jsonfeed.org/version/1",

The version string check is strict because when I wrote it there was only one option. I need to update the lib to support 1.1 of the spec which will have a new version string. Planning on doing a major version bump and only supporting 1.1 in that version forward. Luckily migrating feeds to the new version comes down to putting an array around author fields and pluralizing the key.

If you have a gist or repo example I could look at I can dig in further. I'm guessing from the promise error that maybe data isn't quite making it to the lib due to some promise chain somewhere?

[ralyodio]

Still doesn't work. I get the same error using jsonfeed 1.1

[bcomnes]

I need an example feed that causes problems to do anything with this issue.