Create/Edit UI and Legal API: Allow 30 character names for parties in creation filings (that are not completing party)

[loneil]

As someone incorporating a company through BCROS, I want to be able to use the Incorporator and Director allowable field lengths of 30, so that data lengths in the Lear DB can match what is allowable through maintenance filings.

---

See this ticket for more details and decision: #31797

Will update the validations so that the 20 character COLIN sync maximum only applies for a party that is also the completing party. A director or incorporator can have 30 character length.

--

Dev Notes

The validate_party_name in common_validations is common to the creation filings. A role type inclusion check for completing party would go there. The schema jsons and lear DB are all just 30 characters for all cases already.

Equivalent frontend in Create-UI changes would be needed. Ensure it covers all the cases (incorporation, amalgamation, continuation in, correction)

Make an update to the API spec to detail the conditional character limit

--

QA Notes
Need to be very sure adding the additional character allowance for these does not affect existing behaviour.

• Frontend testing on the Create UI filings
  • Incorporation
  • Amalgamation
  • Continuation In
  • Correction
• For all of these ensure the field length validations work as expected for party names
  • If a party is a completing party, the first and middle are limited to 20
  • If they are not, then 30 characters

The validations here are done in both the UI and the API, so need to check both independently

• Do the same validation checking as above but through API calls, if doing a completing party and you exceed the valid length the error response should inform.

Ensure the COLIN sync for cases of creating entities with parties that have longer name lengths

• If a director is added with > 20 characters (now allowed) then the COLIN sync back does not have any issues and the resultant records have the names as entered through BCROS.

Ensure the deployed API spec includes the note about Completing Party lengths