Edit UI: "undo" Registered Office Contact Info doesn't work #31978
Description
Description
Mihai opened a correction for a coop in Prod. (Note: this reproduces for corps, too.) There was no ROCI email or phone number so the correction was blocked (File and Pay button was disabled).
To test a theory, Mihai entered his own email and phone number.
Then he clicked the "Undo" button to revert the change. On screen, it looked like there was once again no ROCI email or phone number. However, if you look at the dashboard header, the change was not undone:
Presumably, the call to "undo" the email and phone number failed (likely because empty values are rejected). I'm not sure if the endpoint returned an error or if the call failed silently in Auth API, but either way the user was not notified that this failed and in fact, they believed that undo succeeded.
User Story
There is no user story ticket at this time.
Impact
In general, a user cannot "undo" a ROCI email/phone change that would result in an empty email or phone number. These are mandatory fields anyways, so it's probably not an issue that we don't let them undo their changes with empty values.
However, if a user (or staff) entered invalid values, they can't go back to empty values. In this case, IT Ops (or Vysakh or Travis) need to clear the data directly in the database.
Chance of Occurring
This can only happen if the subject business has no Registered Office Contact Information email/phone. I don't know what the chance of that is.
Pre-conditions
The subject business must have no ROCI email/phone in the system.
Steps to Reproduce
See description above.
Expected Behaviour
Clicking the "undo" button reverts the change.
However, since we do not support setting an empty ROCI email/phone, what should we do in this case? Should we somehow convey to the user that they can't set an empty email/phone, even via the Undo button? Should we display an error dialog if they click Undo and the data can't be updated? Should we simply hide the Undo button in this scenario?
Screenshots
See description above.
Root Cause Analysis
See description above.