Merge pull request #480 from bborn/task/1943-expand-task-details-field-to-fill-availa

Expand task details field to fill available space

Author: bborn

internal/ui/form.go

@@ -665,6 +665,8 @@ func (m *FormModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 				m.focused = FieldTitle
 				m.focusCurrent()
 			}
+			// Recalculate body height since available space changes with mode
+			m.updateBodyHeight()
 			return m, nil
 
 		case "ctrl+s":
@@ -1805,51 +1807,35 @@ func (m *FormModel) SetSize(width, height int) {
 	m.updateBodyHeight()
 }
 
-// calculateBodyHeight calculates the appropriate height for the body textarea based on content.
-// Returns a height between minHeight (8) and maxHeight (50% of available screen height).
+// calculateBodyHeight calculates the appropriate height for the body textarea.
+// The body expands to fill all available screen space after accounting for other form elements.
 func (m *FormModel) calculateBodyHeight() int {
-	content := m.bodyInput.Value()
-
-	// Minimum height - increased from 4 to 8 to display more content by default
 	minHeight := 8
 
-	// Maximum height is 50% of screen height
-	// Account for other form elements: header(2) + title(2) + body label(1) + project(2) +
-	// type(2) + schedule(2) + attachments(2) + help(1) + padding/borders(~6) = ~19 lines
-	formOverhead := 22
-	maxHeight := (m.height - formOverhead) / 2
-	if maxHeight < minHeight {
-		maxHeight = minHeight
-	}
+	// Box chrome: border(2) + padding(2) + Height offset(2) = 6
+	boxChrome := 6
 
-	// Count actual lines needed
-	lines := 1
-	if content != "" {
-		lines = strings.Count(content, "\n") + 1
-	}
+	// Non-body content lines common to both modes:
+	// header(1) + blank(1) + title(1) + blank(1) + details label(1) + help(1) = 6
+	commonOverhead := 6
 
-	// Account for line wrapping
-	textWidth := m.width - 24 // Same width as used in SetWidth
-	if textWidth > 0 {
-		for _, line := range strings.Split(content, "\n") {
-			// Each line might wrap based on character count
-			lineLen := len(line)
-			if lineLen > textWidth {
-				lines += lineLen / textWidth
-			}
-		}
+	var modeOverhead int
+	if m.showAdvanced {
+		// Advanced adds: project(1+blank) + attachments(blank+label+input+blank=4) +
+		// type(1+blank) + executor(1+blank) = 10
+		modeOverhead = 10
+	} else {
+		// Simple adds: blank + summary + blank(2) = 3
+		modeOverhead = 3
 	}
 
-	// Apply min/max bounds
-	height := lines
-	if height < minHeight {
-		height = minHeight
-	}
-	if height > maxHeight {
-		height = maxHeight
+	totalOverhead := boxChrome + commonOverhead + modeOverhead
+	availableHeight := m.height - totalOverhead
+	if availableHeight < minHeight {
+		availableHeight = minHeight
 	}
 
-	return height
+	return availableHeight
 }
 
 // updateBodyHeight updates the body textarea height based on content.

internal/ui/form_test.go

@@ -18,44 +18,36 @@ func TestCalculateBodyHeight(t *testing.T) {
 		wantMax      int
 	}{
 		{
-			name:         "empty content returns minimum height",
+			name:         "empty content fills available space",
 			content:      "",
 			screenHeight: 50,
 			screenWidth:  100,
-			wantMin:      8,
-			wantMax:      8,
+			wantMin:      20, // body fills available space (50 - overhead)
+			wantMax:      50,
 		},
 		{
-			name:         "single line returns minimum height",
+			name:         "single line fills available space",
 			content:      "hello world",
 			screenHeight: 50,
 			screenWidth:  100,
-			wantMin:      8,
-			wantMax:      8,
+			wantMin:      20,
+			wantMax:      50,
 		},
 		{
-			name:         "multiple lines grows height",
-			content:      "line1\nline2\nline3\nline4\nline5\nline6",
-			screenHeight: 50,
-			screenWidth:  100,
-			wantMin:      8,
-			wantMax:      8,
-		},
-		{
-			name:         "many lines capped at max height (50% of screen)",
-			content:      strings.Repeat("line\n", 50),
-			screenHeight: 50,
+			name:         "small screen uses minimum height",
+			content:      "",
+			screenHeight: 20,
 			screenWidth:  100,
-			wantMin:      8,  // at least minimum
-			wantMax:      14, // (50-22)/2 = 14
+			wantMin:      8, // minimum height enforced
+			wantMax:      20,
 		},
 		{
-			name:         "long lines wrap and increase height",
-			content:      strings.Repeat("a", 200), // should wrap on ~76 char width
-			screenHeight: 50,
+			name:         "large screen fills more space",
+			content:      "",
+			screenHeight: 100,
 			screenWidth:  100,
-			wantMin:      8,
-			wantMax:      8, // wrapped lines still within minimum
+			wantMin:      50, // more screen = more body space
+			wantMax:      100,
 		},
 	}
 
@@ -79,41 +71,37 @@ func TestCalculateBodyHeight(t *testing.T) {
 func TestUpdateBodyHeightSetsHeight(t *testing.T) {
 	m := NewFormModel(nil, 100, 50, "", nil)
 
-	// Initially should have minimum height of 8
+	// Should fill available space regardless of content
 	m.updateBodyHeight()
 	// The textarea height is internal, so we just verify no panic
 
-	// Add content and update
+	// Add content and update - height stays the same (fills available space)
 	m.bodyInput.SetValue("line1\nline2\nline3\nline4\nline5")
 	m.updateBodyHeight()
-	// Verify no panic and height should be 5
 
-	// Verify that with large content, height is capped
+	// Large content - height is the same (fills available space)
 	m.bodyInput.SetValue(strings.Repeat("line\n", 100))
 	m.updateBodyHeight()
-	// Should be capped at max height (50% of screen)
 }
 
-func TestMaxHeightIs50PercentOfScreen(t *testing.T) {
+func TestBodyHeightFillsAvailableSpace(t *testing.T) {
 	screenHeights := []int{40, 60, 80, 100}
 
 	for _, screenHeight := range screenHeights {
 		t.Run("screen_height_"+string(rune('0'+screenHeight/10)), func(t *testing.T) {
 			m := NewFormModel(nil, 100, screenHeight, "", nil)
 
-			// Add lots of content to trigger max height
-			m.bodyInput.SetValue(strings.Repeat("line\n", 100))
-
 			height := m.calculateBodyHeight()
 
-			// formOverhead is 22, so maxHeight = (screenHeight - 22) / 2
-			expectedMax := (screenHeight - 22) / 2
-			if expectedMax < 8 {
-				expectedMax = 8
+			// Body should fill available space (screen minus overhead)
+			// In advanced mode: boxChrome(6) + common(6) + advanced(10) = 22
+			expectedHeight := screenHeight - 22
+			if expectedHeight < 8 {
+				expectedHeight = 8
 			}
 
-			if height > expectedMax {
-				t.Errorf("height %d exceeds expected max %d for screen height %d", height, expectedMax, screenHeight)
+			if height != expectedHeight {
+				t.Errorf("height %d != expected %d for screen height %d", height, expectedHeight, screenHeight)
 			}
 		})
 	}